Fix some issues with newly added outputs#713
Conversation
JorgSchwinger
requested review from
TomasTorsvik,
jmaerz and
matsbn
as code owners
TomasTorsvik
left a comment
TomasTorsvik
left a comment
There was a problem hiding this comment.
@JorgSchwinger - thanks for fix! It looks fine to me.
| ! --- Compute log10 of pH | ||
| !if (SRF_PH(iogrp).ne.0) call logsrf(jsrfph(iogrp),rnacc,0._rp) | ||
| !if (LYR_PH(iogrp).ne.0) call loglyr(jph(iogrp),1._rp,0._rp) | ||
| !if (LVL_PH(iogrp).ne.0) call loglvl(jlvlph(iogrp),rnacc,0._rp) | ||
| !if (use_natDIC) then | ||
| ! if (SRF_NATPH(iogrp).ne.0) call logsrf(jsrfnatph(iogrp),rnacc,0._rp) | ||
| ! if (LYR_NATPH(iogrp).ne.0) call loglyr(jnatph(iogrp),1._rp,0._rp) | ||
| ! if (LVL_NATPH(iogrp).ne.0) call loglvl(jlvlnatph(iogrp),rnacc,0._rp) | ||
| !endif |
There was a problem hiding this comment.
Maybe just remove this comment block?
jmaerz
left a comment
jmaerz
left a comment
There was a problem hiding this comment.
Looks good to me. Could you provide the details, how and why the O2_min is used? - also that no depth seems to be attached to it (i.e. depth can vary from time step to time step)? A little bit strange output to me, but likely needed?!
|
@JorgSchwinger - is this ready for merging? |
Hi @jmaerz , I agree this is a bit strange, particularly without depth information, but this is what the CMIP7 data request says. We might add the depth information in a later PR to have it available. |
3 participants
This PR fixes some issues that have brought up during review of #711 but have not been solved before merging. Importantly, pH is now averaged consistently as pH (not as [H+]).