Added options for enthalpy correction and new ZM options#227
Added options for enthalpy correction and new ZM options#227oyvindseland wants to merge 6 commits intoNorESMhub:noresm_developfrom
Conversation
…uritzen (NCAR) and Thomas Toniazzo (Bjerknes Centre / NORCE) and option for ZM changes programmed by Thomas Toniazzo
|
Restart test (2 months and 1+1 month) give bfb results with all options on |
|
PR updated with development branch merge |
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
This is a preliminary review addressing some structural issues.
| </entry> | ||
| <entry id="zmconv_entrmn" type="real" category="conv" | ||
| group="zmconv_nl" valid_values="" > | ||
| tht: previously undeclared par: max entr. rate for plume-ens |
There was a problem hiding this comment.
Please spell this out without abbreviations and unhelpful comments. Also, what are the units?
There was a problem hiding this comment.
unknown / none. Not a new parameter, but previously hardcoded in ZM
| call pbuf_add_field('UMS', 'physpkg', dtype_r8, (/pcols,pver/), ums_idx) | ||
| call pbuf_add_field('QCSEVAP', 'physpkg', dtype_r8, (/pcols,pver/), qcsevap_idx) | ||
| call pbuf_add_field('QISEVAP', 'physpkg', dtype_r8, (/pcols,pver/), qisevap_idx) | ||
| !+tht |
There was a problem hiding this comment.
All these comments are unnecessary and distracting. Please remove them.
| nrain_idx=-1, nsnow_idx=-1, & | ||
| qcsedten_idx=-1, qrsedten_idx=-1, & | ||
| qisedten_idx=-1, qssedten_idx=-1, & | ||
| qisedten_idx=-1, qssedten_idx=-1, qgsedten_idx=-1, & !+tht |
There was a problem hiding this comment.
There should be no files in camnor_phys. These files all belong in https://github.com/NorESMhub/CAM-Nor-physics and after that tag is made, it should be added back as a CAM external.
| add_default($nl, 'zmconv_capelmt'); | ||
| add_default($nl, 'zmconv_tau'); | ||
| add_default($nl, 'zmconv_parcel_hscale'); | ||
| #+tht |
| </entry> | ||
| <entry id="zmconv_alfadet" type="real" category="conv" | ||
| group="zmconv_nl" valid_values="" > | ||
| tht: previously undeclared param: detrainment/entrainment |
There was a problem hiding this comment.
Please spell this out without abbreviations and unhelpful comments. Also, what are the units?
There was a problem hiding this comment.
Unit: unknown / none. Not a new parameter, but previously hardcoded in ZM
| </entry> | ||
| <entry id="zmconv_plclmin" type="real" category="conv" | ||
| group="zmconv_nl" valid_values="" > | ||
| tht: previously undeclared param: min LCL pressure to allow zm |
There was a problem hiding this comment.
Please spell this out without abbreviations and unhelpful comments. Also, what are the units?
There was a problem hiding this comment.
Unit: unknown / none. Not a new parameter, but previously hardcoded in ZM
github-project-automation
bot
moved this from Todo
to In Progress
in NorESM Development
|
@oyvindseland, I can do a cleanup pass and push to your PR branch if that is okay with you. Let me know. |
|
Hi Yes it is good if you can do a clean-up and push to my branch. Thank you. |
|
Updated units |
|
Merged with head. |
|
This PR is superseded by:
Also depends on other component PRs: |
|
The PR #240 supercedes this PR - slo closing. |
3 participants
Summary: Added options for enthalpy correction and new ZM options
Contributors: Øyvind Seland; Thomas Toniazzo; Peter Lauritzen
Reviewers: @gold2718
Purpose of changes: #225
Github PR URL: #227
Changes made to build system: None
Changes made to the namelist: Added option for enthalpy corrections and added options for zm modifcations and namelist tuning options. Default of pull request is everything off.
Changes to the defaults for the boundary datasets: None
Substantial timing or memory changes: None
Added options for enthalpy correction programmed by indicate Peter Lauritzen (NCAR) and Thomas Toniazzo (Bjerknes Centre / NORCE) and option for ZM changes programmed by Thomas Toniazzo
Added path physics/camnor_phys/physics/ All new and modified subroutines entered in this directory including ZM files The directory already exists in the build options so not needed to modify this
[ List each test suite run. For each suite, include machine, compiler, and any test failures.
-AMIP test showing that the default with every new option turned off give bit-identical result to the original tag
Code author has done a coupled experiment with the options on.
Issues addressed by this PR: #225