15_fatespftx14_hlmpft_paramfile#53
Closed
rosiealice wants to merge 2 commits intoNorESMhub:noresmfrom
Closed
Conversation
Collaborator
Author
5 tasks
Collaborator
Author
|
closing as superceded by #52 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a 15th parameter to the FATES parameter description, which is intended as a crop. The crop PFT is assigned area differently to the others and the index of the fates_landuse_crop_lu_pft_vector variable is used (previously 13, now 15) to define it.
When this parameter file is used, a seperate PFT is created for crop which is generated during land use change via the allocation of crop area to PFT 15.
For now it is functionally identical to PFT 13 (cool C3 grass) but we may make it have different physiology in a follow up PR.
This file was generated from the file in #52 using the following command of in fates/tools directory:
python FatesPFTIndexSwapper.py --fin ../parameter_files/fates_params_default_14fpft.nc --fout fates_params_default_crops.nc --pft-indices 1,2,3,4,5,6,7,8,9,10,11,12,13,14,13
where
fates_params_default_14fpft.nc is created first from fates_params_default.cdl using NCGEN.
In this process, the order of the variables appears to have been swopped around somewhat. I don't know if this is the intended functioality of the tool. I have done it three times and each time the result has been the same. This makes it harder to look at the differnences introduced by this PR.
In principle the physiology of this should be identical to previous runs, and so this change -should- be BFB, with a following wind? Maybe there are some methodoligical differences in the area allocation that would prevent it from being identical. I anticipate it would be identical scientifically.
Addresses this issue:
NorESMhub/CTSM#194
Description:
Collaborators:
Expectation of Answer Changes:
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: