Fixed GetOrSet redis read. #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelNygren-Norce
requested changes
Oct 28, 2025
| var redisValue = GetRedisValue(k); | ||
| if (!redisValue.IsNull) | ||
| { | ||
| var ttlValue = TTLValue.FromRedisValue<T>(Encoding.ASCII.GetBytes(redisValue.ToString())); |
Contributor
There was a problem hiding this comment.
add a HzActivities.Source.StartActivityWithCommonTags so we can see the time here
| var redisBackedValueFactory = new Func<string, Task<T>>(async k => | ||
| { | ||
| var redisValue = await GetRedisValueAsync(k).ConfigureAwait(false); | ||
| if (!redisValue.IsNull) |
Contributor
There was a problem hiding this comment.
add a HzActivities.Source.StartActivityWithCommonTags so we can see the time here
JoelNygren-Norce
approved these changes
Oct 28, 2025
| } | ||
|
|
||
| private Task<RedisValue> GetRedisValueAsync(string key) | ||
| { |
Contributor
There was a problem hiding this comment.
can we add a using var activity = HzActivities.Source.StartActivityWithCommonTags(HzActivities.Names.GetFromRedis, key,async;true);
|
|
||
| private RedisValue GetRedisValue(string key) | ||
| { | ||
| return redisDb.StringGet(GetRedisKey(key)); |
Contributor
There was a problem hiding this comment.
can we add a using var activity = HzActivities.Source.StartActivityWithCommonTags(HzActivities.Names.GetFromRedis, key,async;false);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.