Skip to content

Fix #286, #348, #349 - #350

Merged
lars-t-hansen merged 1 commit into
mainfrom
larstha-286-crossbeam
Sep 1, 2025
Merged

Fix #286, #348, #349#350
lars-t-hansen merged 1 commit into
mainfrom
larstha-286-crossbeam

Conversation

@lars-t-hansen

@lars-t-hansen lars-t-hansen commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator

Fix #286 - mpsc -> crossbeam::channel; make Kafka interface use it
Fix #348 - signal handling for daemon via signal_hook crate
Fix #349 - handle signals in ps via signal_hook crate
Removes existing signal handling module
Test scaffolding
Test cases - many new and some cleaned up

Comment thread src/datasink/kafka.rs Outdated
Comment thread src/datasink/kafka.rs Outdated
@lars-t-hansen
lars-t-hansen requested a review from bast August 29, 2025 07:48
@lars-t-hansen

lars-t-hansen commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator Author

@bast, FYI in case you want to take a look. I've given up on supply chain security - I'll never get anywhere that way, and with the previous rdkafka dependency that ship sailed anyway.

Fix #348 - signal handling for daemon via signal_hook crate
Fix #349 - handle signals in ps via signal_hook crate
Test cases
@lars-t-hansen
lars-t-hansen merged commit 4f6983f into main Sep 1, 2025
4 checks passed
@lars-t-hansen
lars-t-hansen deleted the larstha-286-crossbeam branch September 1, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup: Signal handling for ps should use signal_hook Daemon mode must handle SIGTERM Switch from mpsc to crossbeam

1 participant