feat: add bundled SectionCampaign mode #299
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timowestnosto
force-pushed
the
bundled-campaign
branch
from
8e98a26 to
98cb623
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new BundledCampaign custom element that fetches Nosto placement results and renders them using Shopify's Bundled Section Rendering API. The campaign metadata is persisted in cart attributes for tracking purposes.
Key changes:
- Added
postJSONutility function to handle POST requests with JSON payloads - Created new
BundledCampaigncomponent that integrates with Nosto's recommendation API and Shopify's cart system - Enhanced fetch utilities to support configurable request options
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/utils/fetch.ts |
Added postJSON function and enhanced fetchWithErrorHandling to accept optional request options |
src/components/BundledCampaign/BundledCampaign.ts |
New custom element implementation for bundled campaign functionality with Shopify integration |
timowestnosto
force-pushed
the
bundled-campaign
branch
4 times, most recently
from
52e8b99 to
33b35ce
Compare
timowestnosto
changed the title
timowestnosto
force-pushed
the
bundled-campaign
branch
4 times, most recently
from
be8abbd to
28de060
Compare
timowestnosto
force-pushed
the
bundled-campaign
branch
from
28de060 to
a1819d4
Compare
| async function getSectionMarkup(element: SectionCampaign, rec: JSONResult) { | ||
| const handles = rec.products.map(product => product.handle).join(":") | ||
| async function getBundledMarkup(element: SectionCampaign, handles: string, rec: JSONResult) { | ||
| const target = new URL("/cart/update.js", window.location.href) |
There was a problem hiding this comment.
Use with locale
`${window.Shopify.routes.root}cart/update.js`
| } | ||
|
|
||
| async function getSectionMarkup(element: SectionCampaign, handles: string, rec: JSONResult) { | ||
| const target = new URL("/search", window.location.href) |
There was a problem hiding this comment.
${window.Shopify.routes.root}search'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add new Section Campaign mode to fetch rendered section via Bundled Section Rendering API
Compared to the previous mode this supports self references of sections and blocks
Related Jira ticket
Screenshots