-
-
Notifications
You must be signed in to change notification settings - Fork 4
Versioning #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Versioning #11
Changes from 8 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
7d98cb3
Add version bump script
NullPointerDepressiveDisorder a02e9d2
Trigger homebrew update after release
NullPointerDepressiveDisorder ba518b7
Add check for existing version tag before tagging
NullPointerDepressiveDisorder 41b22a1
Update .github/workflows/release.yml
NullPointerDepressiveDisorder bd46698
Update bump-version.sh
NullPointerDepressiveDisorder 3c1a43c
Update bump-version.sh
NullPointerDepressiveDisorder da21e4c
Update .github/workflows/release.yml
NullPointerDepressiveDisorder 094a95b
Merge branch 'main' into versioning
NullPointerDepressiveDisorder d49ac5f
Apply suggestions from code review
NullPointerDepressiveDisorder 4818e3f
Add Homebrew Update workflow trigger
NullPointerDepressiveDisorder d0e1a59
Add repository_dispatch event for homebrew_release
NullPointerDepressiveDisorder fa06262
Update .github/workflows/release.yml
NullPointerDepressiveDisorder f34900b
Update .github/workflows/release.yml
NullPointerDepressiveDisorder 65bba22
Initial plan
Copilot 37f5170
Merge pull request #12 from NullPointerDepressiveDisorder/copilot/sub…
NullPointerDepressiveDisorder 0819478
Update .github/workflows/release.yml
NullPointerDepressiveDisorder cdd47e6
Add GH_TOKEN to version retrieval in release workflow
NullPointerDepressiveDisorder 4891f85
Update .github/workflows/release.yml
NullPointerDepressiveDisorder f2177e6
Fix output variable name in release workflow
NullPointerDepressiveDisorder ed87cc8
Update .github/workflows/release.yml
NullPointerDepressiveDisorder abcdd3a
Apply suggestions from code review
NullPointerDepressiveDisorder 8dc256d
Remove Create Release step and add Homebrew trigger
NullPointerDepressiveDisorder 5ae4d67
Update .github/workflows/release.yml
NullPointerDepressiveDisorder 1ec7daa
Update bump-version.sh
NullPointerDepressiveDisorder ffe3779
Update bump-version.sh
NullPointerDepressiveDisorder e56e58e
Update .github/workflows/release.yml
NullPointerDepressiveDisorder 99dfe3b
Restore release creation and add version validation to release workflow
google-labs-jules[bot] 29a14c3
Update .github/workflows/release.yml
NullPointerDepressiveDisorder bb3a4fb
Restore release creation, add version validation, and fix env var case
google-labs-jules[bot] d267647
Restore release creation, add version validation, and fix env var cas…
google-labs-jules[bot] fa21bdf
Update .github/workflows/release.yml
NullPointerDepressiveDisorder 142bbdf
Merge pull request #13 from NullPointerDepressiveDisorder/fix-release…
NullPointerDepressiveDisorder 88b8af5
Update .github/workflows/release.yml
NullPointerDepressiveDisorder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| #!/bin/bash | ||
|
NullPointerDepressiveDisorder marked this conversation as resolved.
|
||
| # bump-version.sh - Update version in Xcode project and create git tag | ||
|
|
||
| set -e | ||
|
|
||
| VERSION=$1 | ||
|
|
||
| if [ -z "$VERSION" ]; then | ||
| echo "Usage: ./bump-version.sh <version>" | ||
| echo "Example: ./bump-version.sh 1.2.3" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Remove 'v' prefix if provided | ||
| VERSION="${VERSION#v}" | ||
|
|
||
| # Validate semver format | ||
| if ! [[ "$VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then | ||
| echo "Error: Version must be in semver format (e.g., 1.2.3)" | ||
| exit 1 | ||
| fi | ||
|
|
||
|
NullPointerDepressiveDisorder marked this conversation as resolved.
|
||
| # Ensure working directory is clean | ||
| if ! git diff-index --quiet HEAD --; then | ||
| echo "Error: Working directory has uncommitted changes. Please commit or stash them first." | ||
| exit 1 | ||
| fi | ||
| echo "Bumping version to $VERSION..." | ||
|
|
||
| # Update Xcode project MARKETING_VERSION (both Debug and Release configs) | ||
|
NullPointerDepressiveDisorder marked this conversation as resolved.
|
||
| sed -i '' "s/MARKETING_VERSION = [0-9]*\.[0-9]*\.[0-9]*/MARKETING_VERSION = $VERSION/g" \ | ||
|
NullPointerDepressiveDisorder marked this conversation as resolved.
Outdated
|
||
| MiddleDrag.xcodeproj/project.pbxproj | ||
|
|
||
|
NullPointerDepressiveDisorder marked this conversation as resolved.
|
||
| # Validate that MARKETING_VERSION was updated | ||
| if ! grep -q "MARKETING_VERSION = $VERSION" MiddleDrag.xcodeproj/project.pbxproj; then | ||
| echo "Error: Failed to update MARKETING_VERSION in project file" | ||
| exit 1 | ||
|
NullPointerDepressiveDisorder marked this conversation as resolved.
Outdated
|
||
| fi | ||
| echo "✓ Updated MARKETING_VERSION in Xcode project" | ||
|
|
||
| # Stage and commit | ||
| git add MiddleDrag.xcodeproj/project.pbxproj | ||
| git commit -m "Bump version to $VERSION" | ||
| echo "✓ Committed version change" | ||
|
|
||
| # Create tag | ||
| if git rev-parse "v$VERSION" >/dev/null 2>&1; then | ||
| echo "Error: Tag v$VERSION already exists" | ||
| exit 1 | ||
| fi | ||
|
|
||
| git tag "v$VERSION" | ||
|
NullPointerDepressiveDisorder marked this conversation as resolved.
|
||
| echo "✓ Created tag v$VERSION" | ||
|
|
||
|
NullPointerDepressiveDisorder marked this conversation as resolved.
Outdated
|
||
| echo "" | ||
| echo "Done! To trigger the release workflow, run:" | ||
| echo " git push && git push --tags" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.