Use more functions from TrixiTest.jl - #226
Merged
Merged
Conversation
Contributor
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
Why were they not included the first time? I just reran the script...
Collaborator
Pull Request Test Coverage Report for Build 16500908095Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With TrixiTest.jl v0.1.3 we have some more functionality in the common TrixiTest.jl, which can be reused here. Note that we need a custom
@test_trixi_include_basebecause it looks quite different compared to the one in TrixiTest.jl, but I also adapted to the new style, where we have a@test_trixi_include_baseand a@test_trixi_includeto stay consistent and avoid confusion.Regarding the
@test_allocations, we now also need to pass therhs!to the macro.For potential future reference, here is the script I used to replace all occurrences