Skip to content

Revert workaround related to Coveralls on MacOS - #311

Merged
JoshuaLampert merged 1 commit into
mainfrom
revert-coveralls-workaround
Jul 29, 2026
Merged

Revert workaround related to Coveralls on MacOS#311
JoshuaLampert merged 1 commit into
mainfrom
revert-coveralls-workaround

Conversation

@JoshuaLampert

Copy link
Copy Markdown
Member

Revert the workaround introduced in #308 since the underlying issue has been resolved in the coveralls GitHub action.

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1.10)

Time benchmarks
main fe63313... main / fe63313...
bbm_1d/bbm_1d_basic.jl - rhs!: 9 ± 0.35 μs 11 ± 0.49 μs 0.821 ± 0.049
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.143 ± 0.01 ms 0.144 ± 0.0095 ms 0.99 ± 0.096
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0563 ± 0.0067 ms 0.0502 ± 0.00042 ms 1.12 ± 0.13
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 20.4 ± 0.52 μs 20.2 ± 1.2 μs 1.01 ± 0.066
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 17.7 ± 0.54 μs 17.9 ± 0.66 μs 0.99 ± 0.047
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 24.9 ± 1.3 μs 24.9 ± 1.6 μs 1 ± 0.082
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 3.26 ± 0.024 μs 3.24 ± 0.027 μs 1.01 ± 0.011
kdv_1d/kdv_1d_basic.jl - rhs!: 0.957 ± 0.014 μs 0.956 ± 0.015 μs 1 ± 0.021
kdv_1d/kdv_1d_implicit.jl - rhs!: 0.945 ± 0.011 μs 0.938 ± 0.014 μs 1.01 ± 0.019
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.131 ± 0.011 ms 0.129 ± 0.01 ms 1.01 ± 0.12
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.103 ± 0.0071 ms 0.104 ± 0.014 ms 0.989 ± 0.15
time_to_load 1.67 ± 0.037 s 1.7 ± 0.023 s 0.979 ± 0.026
Memory benchmarks
main fe63313... main / fe63313...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@JoshuaLampert
JoshuaLampert requested a review from ranocha July 29, 2026 15:45
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ranocha ranocha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ranocha
ranocha enabled auto-merge (squash) July 29, 2026 15:54
@JoshuaLampert
JoshuaLampert disabled auto-merge July 29, 2026 16:06
@JoshuaLampert
JoshuaLampert merged commit 8a49647 into main Jul 29, 2026
11 checks passed
@JoshuaLampert
JoshuaLampert deleted the revert-coveralls-workaround branch July 29, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants