Skip to content

Mark gaz as inactive until issues resolved #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2021
Merged

Conversation

matentzn
Copy link
Contributor

Discussed at OBO operations call today.

There are some fundamental problems with GAZ:

  • geographic location is an instance
  • GAZ has not been updated
  • ENVO should be the classes from GAZ, GAZ should be for instances
  • GAZ is inconsistent.

cmungall added a commit to information-artifact-ontology/IAO that referenced this pull request Jul 13, 2021
'postal address is about some geographic location'

GAZ should not be used for classes, see OBOFoundry/OBOFoundry.github.io#1552

Fixes obi-ontology/obi#1375

Note that in the future if the is-about axiom is truly valuable
(I suspect not) then it can be added back using a GEO class or an ENVO class
@matentzn matentzn added the attn: OFOC call Issue to discuss on fortnightly OBO Operations meeting label Jul 13, 2021
@cmungall cmungall requested a review from pbuttigieg July 14, 2021 18:21
@cmungall
Copy link
Contributor

I think it's undecided whether the source of classes should be GEO or ENVO cc @mbrochhausen @pbuttigieg -- these ontologies are not orthogonal -- but the overall point remains that GAZ shouldn't be the source of classes here

@cmungall
Copy link
Contributor

Note there are many tickets for discussing plans to rescue gaz here: https://github.com/EnvironmentOntology/gaz/issues -- I welcome discussion over here

@mellybelly
Copy link
Contributor

mellybelly commented Jul 14, 2021

I agree this should be marked inactive. I don't think we need it when other standards such as geonames exist. I view it more like the issues with making gene names available for axioms.

@addiehl
Copy link

addiehl commented Aug 10, 2021

Revision in progress per Lynn. Making a file without instances. Will be just a country list.

We will revisit this in November.

@matentzn
Copy link
Contributor Author

In conversation with @lschriml on slack, we will mark GAZ as inactive until she finishes her revisions, at which point we will change it back to active. If anyone sees this comment uncommented after 1 week, you can merge.

@nlharris
Copy link
Contributor

This PR has one approving review; does it need more reviews before it can be merged?

@matentzn matentzn merged commit 5fb64ff into master Aug 22, 2021
@matentzn matentzn deleted the matentzn-patch-10 branch August 22, 2021 14:57
@lschriml
Copy link
Contributor

Reopening this pull request, to 're-activate' the gaz. See ticket:
#2108

Lynn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attn: OFOC call Issue to discuss on fortnightly OBO Operations meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants