Skip to content

Conversation

@pedrobaeza
Copy link
Member

@pedrobaeza pedrobaeza commented Nov 27, 2019

Using window function OVER (PARTITION BY ...), as explained in PostgreSQL wiki:

https://wiki.postgresql.org/wiki/Deleting_duplicates

In a real DB, it passes from requiring almost 10 minutes to require only 3 seconds.

cc @Tecnativa TT20635

@pedrobaeza pedrobaeza added this to the 12.0 milestone Nov 27, 2019
Using window function OVER (PARTITION BY ...), as explained in PostgreSQL wiki:

https://wiki.postgresql.org/wiki/Deleting_duplicates

In a real DB, it passes from requiring almost 10 minutes to require only 3 seconds.
@pedrobaeza pedrobaeza force-pushed the 12.0-base-ir_translation-delete_imp branch from de112ea to b57a57a Compare November 27, 2019 23:51
@pedrobaeza pedrobaeza changed the title [WIP][IMP] base: Index ir_translation for faster removal [12.0][IMP] base: Faster ir_translation removal Nov 27, 2019
@pedrobaeza
Copy link
Member Author

Ready to be reviewed.

@pedrobaeza pedrobaeza closed this Nov 27, 2019
@pedrobaeza pedrobaeza reopened this Nov 27, 2019
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@StefanRijnhart
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-2092-by-StefanRijnhart-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-2092-by-StefanRijnhart-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 6, 2019
Signed-off-by StefanRijnhart
@OCA-git-bot OCA-git-bot merged commit b57a57a into OCA:12.0 Dec 6, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8187780. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 12.0-base-ir_translation-delete_imp branch November 18, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants