-
-
Notifications
You must be signed in to change notification settings - Fork 785
[12.0][IMP] base: Faster ir_translation removal #2092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][IMP] base: Faster ir_translation removal #2092
Conversation
Using window function OVER (PARTITION BY ...), as explained in PostgreSQL wiki: https://wiki.postgresql.org/wiki/Deleting_duplicates In a real DB, it passes from requiring almost 10 minutes to require only 3 seconds.
de112ea to
b57a57a
Compare
|
Ready to be reviewed. |
MiquelRForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
StefanRijnhart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
|
/ocabot merge |
|
On my way to merge this fine PR! |
|
It looks like something changed on |
|
Congratulations, your PR was merged at 8187780. Thanks a lot for contributing to OCA. ❤️ |
Using window function OVER (PARTITION BY ...), as explained in PostgreSQL wiki:
https://wiki.postgresql.org/wiki/Deleting_duplicates
In a real DB, it passes from requiring almost 10 minutes to require only 3 seconds.
cc @Tecnativa TT20635