[12.0] update upstream 1341cc6ab92 #2219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: - install pos - install the hebrew language and set it as preferred language - start a pos session with the virtual keyboard option activated - try to search a product Previous behavior: the keyboard keys are reversed Current behavior: the keyboard keys are not reversed opw-2171278 closes odoo/odoo#44307 Signed-off-by: Nicolas Lempereur (nle) <[email protected]>
…c accounting Before this commit, when installing the Dominican Republic accounting, multiple tests give false positives. This arises because some tests depends on the installed Chart of Accounts. Now, the tests are done in a more global way, to avoid the dependence on the CoA. closes #42726 opw-2167368 closes odoo/odoo#44376 Signed-off-by: Laurent Smet <[email protected]>
- Have a fresh v12.0 database with point_of_sale and account_accountant
- General settings
- Activate cash basis
- Activate unit of measure
- Taxes
- Have a tax A with percentage, included in price, tax due based on payment
- Duplicate the tax A->B and put tax B due based on invoice
- Fiscal position
- Have a fiscal position F with no mapping (empty)
- Have a fiscal position G that map the tax A to tax B
- Product
- Set the tax A on a product P
- Set product A unit of measure to be grouped in POS
- POS sessions config
- Have POS session S, open its config
- Add fiscal position F & G in fiscal position per order
- Add fiscal position F in fiscal position
- Set show tax included in price
- POS session
- Open POS session S
- Choose fiscal position F
- Click on product P multiple times, it stacks as required
- Choose fiscal position G
- Click on product P multiple times, it does not stack, but it should
This happen because the function which check if the orderlines can
be merged do not compute correctly the price after the fiscal position,
so there will be a mismatch
opw-2171042
closes odoo/odoo#44390
Signed-off-by: Nicolas Lempereur (nle) <[email protected]>
When the multi-location is enabled, in the stock picking form, when the picking is unlocked, we can't modify move lines in the wizard, due to a bad readonly attribute which doesn't take in account 'is_locked' field. closes odoo/odoo#44360 Signed-off-by: Arnold Moyaux <[email protected]>
When making a payment for multiple vendor bills at once, it is possible that payments will be generated without any recipient bank account for payment methods normally requiring one. In such cases, the user needs to be able to correct the payments by cancelling them. It was not possible. closes odoo/odoo#44406 Signed-off-by: Laurent Smet <[email protected]>
Steps to reproduce the bug: - Let's consider two product temlpates PT1 and PT2 - Let's consider one attribute A with create_variant = 'no_variant' - Add A on PT1 and PT2 - Allow to compare products on the settings of website - Go to website and compare PT1 and PT2 Bug: The attribute A was displayed in the comparator even if there was no variant for this attribute. opw:2167182 closes odoo/odoo#44340 Signed-off-by: Simon Goffin (sig) <[email protected]>
- When reports print with long string in footer will spoil layout. This issue will fix that. Task ID: 1960423 Closes at #33271 closes odoo/odoo#35097 closes odoo/odoo#44448 Signed-off-by: Damien Bouvy (dbo) <[email protected]> Signed-off-by: Nicolas Martinelli (nim) <[email protected]>
- Create an invoice for 1000 - Make a partial payment (e.g. cash) for 250 - Print the ISR The ISR contains an amount of 1000 (total amount), while it should be 750 (amount left to pay). opw-2180538 closes odoo/odoo#44488 X-original-commit: f174a56 Signed-off-by: Nicolas Martinelli (nim) <[email protected]>
It very rarely happens that the test is failing due to the following error:
`Tour shop_list_view_b2c failed at step
.oe_product_cart .oe_currency_value:contains("825.00")`
The value found in that case is 750 instead of 825, which indicates that the b2c
setting was not correctly activated.
To exclude the RPC themselves from the equation, it is decided here to move the
setting change directly in the Python.
closes odoo/odoo#44492
Signed-off-by: Romain Derie <[email protected]>
Incorrect backport of 7641356 Closes #44489 closes odoo/odoo#44519 X-original-commit: 49c338ed506a0fe28d77b9e1c68368d2f2bd22fa Signed-off-by: Nicolas Martinelli (nim) <[email protected]>
Before this commit, Creating New Template from "Send Invoice" wizard doesn't update template_id on the Wizard. In this commit, We write newly created template_id on the wizard. closes odoo/odoo#42655 Signed-off-by: Laurent Smet <[email protected]>
Before this change a call to `record.mapped(...)` for relational fields
did not preserve the prefetch info. Let's take the following code as an
example:
order = self.env[sale.order].browse(7)
order.mapped("order_line.name")
for line in order.order_line:
print(line.product_id.name)
Before this change, each call to `line.product_id.name` generated 1 SQL
query. After this change, only 1 SQL query is done for all the products
the first time the name field is read.
The prefetching of all simple fields of order line records will add
prefetch information about product records in `order`'s prefetch object.
This is what makes prefetching work better.
This change optimizes the onchange methods where a lot of calls to the
`mapped` method are done.
closes odoo/odoo#44591
X-original-commit: e2e537f
Signed-off-by: Raphael Collet (rco) <[email protected]>
Co-authored-by: Laurent Mignon <[email protected]>
…ding issue It is possible to have unrounded lines taken into account to compute the total amount (due to known ORM weirdness). When this happened, it was possible to have a matched percentage of 0.999999999 instead of 1. This caused in turn the reconciliation functions not to detect full reconciliation, hence not creating any account.full.reconcile object. Account move lines were then marked as reconciled, with 0 amount_residual and no full_reconcile_id, hence no matching number shown. This was wrong. Using balance instead of debit-credit ensures no rounding error, as it is computed. OPW 2183094 closes odoo/odoo#44567 X-original-commit: 8df4408 Signed-off-by: oco-odoo <[email protected]>
Create a demo fiscal position. Create a new Vendor with such fiscal position assigned. Create a product in which the product category has an account which can be mapped with the demo fiscal position Create a new Vendor Bill, select the partner, create an invoice line, fill in the product: account will be autofilled already mapped. Create a new invoice line, fill in the description: account will be taken from the Vendor Bill>default debit/credit account and will not be mapped according to the Vendor fiscal position. This happens because there is no mapping involved in the procedure. Adding fiscal position mapping code fix the issue opw-2184509 closes odoo/odoo#44575 Signed-off-by: Nicolas Martinelli (nim) <[email protected]>
The typical command to launch odoo in the install documentation is usable as it is after following the complete instructions. There is two changes done here: - Remove the ../my_modules from the command, as it is a directory not used in the page at all. - Remove the db-filter option not mandatory since the 11.0 version and add a '-d' argument. This will create the db instead of showing the database selector to the reader. closes odoo/odoo#44220 X-original-commit: 398a3d7 Signed-off-by: Denis Ledoux (dle) <[email protected]>
Steps to reproduce: - install sales and easypost shipping - have a delivery order of multiple packages with easypost - click "send confirmation email" previous behavior: the template does not handle multiple package references and the associated link is wrong current behavior: each reference is set in a separated link opw-2167037 closes odoo/odoo#44174 Signed-off-by: Nicolas Lempereur (nle) <[email protected]>
Imagine a total of -100 in category TEST. Now another line for category TEST is processed with an amount of 100. The following now evaluates to 0: localdict['categories'].dict[category.code] + amount Which is falsy so now the "or amount" is used instead. Instead of a total category sum of 0 we end up with a sum of 100. To solve the issue be a bit less clever and use a good old if. opw-2191589 closes odoo/odoo#44684 Signed-off-by: Nicolas Martinelli (nim) <[email protected]>
1) Go to purchasing, and in the search area type "8888" 2) Click on the little arrow next to "Search Product for: 8888" 3) Select "[FURN_8888] Office Lamp" 4) Choose Purchase Order PO00009 which has FURN_8888 on the second line: 5) Choose Action > Duplicate The 1st line end up with the searched product, not the original product. This happens because the search add the context key 'default_product_id'. By chance the product.product model has a 'product_id' field which may happen to be not filled. This cause the model api to look for a default value in the context and the first line of the order get overridden. Removing the specific key from the env solve the issue opw-2188429 closes odoo/odoo#44598 Signed-off-by: Nicolas Martinelli (nim) <[email protected]>
As an admin or website publisher, you have the possibility to switch website in the navbar. This will force a website in your session*. If this website is removed at some point, your session will be broken as the dispatch will lead to a traceback, trying to read un unexisting website. * There is other way to have the website forced in the session: theme install, go to website from settings, create website from settings.. opw-2092845
The user is never able to delete a website, since there is at least one page, the homepage, which is bootstraped during website creation. From that point, even if nothing was done on that website, it was not possible to remove it. As website deletion is already a technical thing (debug mode), and since website.page do not make sense without their website, removing those on cascade will allow the user to remove a non-modified website. task-2092845 closes odoo/odoo#44665 Signed-off-by: Jérémy Kersten (jke) <[email protected]>
-In the action menu, the manager has no rights to delete the scrap order thus added the access rights for the manager in the main csv file. task-1959647 closes odoo/odoo#44702 Signed-off-by: Nicolas Martinelli (nim) <[email protected]>
- Install helpdesk_stock - Publish the team Customer Care on the website - Edit the ticket submission form - Add the field 'Lot/Serial Number' A crash occurs because of a malformed domain. It happens because the domain is a string, and therefore should be evaluated. We remove the string domains since it won't be possible to evaluated them in the website form anyway. opw-2176144 closes odoo/odoo#43409 closes odoo/odoo#44758 Original-signed-off-by: Nicolas Martinelli (nim) <[email protected]> X-original-commit: 2bf80fc Signed-off-by: Nicolas Martinelli (nim) <[email protected]>
The translation alert dialog was attached to the entire view in case no
status bar was found. This resulted in the following layout on large
screens:
chrome
--------------------------------------
| alert dialog | form view | chatter |
| | | |
--------------------------------------
Whereas when a status bar was set on the form view, the rendering was as
follow:
chrome
--------------------------------------
| status bar | chatter |
| alert dialog | |
| form view | |
--------------------------------------
The fix make sure the alert dialog is always placed just above the form
view just like when there is a status bar.
closes odoo/odoo#44763
Task: 2075172
X-original-commit: 92f168299c92426c64ce2941f76e7921f77d6e94
Signed-off-by: Julien Castiaux <[email protected]>
Without these magic filters the various options in the activity widget (late, today, future) will show all activities instead. opw-2172833 closes odoo/odoo#44535 Signed-off-by: jorenvo <[email protected]>
On product categories, the `total_route_ids` field is shown without label. This is confusing for end users since the same route seems to appear twice. opw-2173783 closes odoo/odoo#44786 X-original-commit: 91bc646 Signed-off-by: Nicolas Martinelli (nim) <[email protected]>
Before that, depending on rounding errors on floats, it was possible to end up with a matched percentage of 0.999999999 instead of 1.0 on an account move in case of full reconciliation. This could in turn cause problems with cash basis taxes, when checking what proportion of the move is reconciled. closes odoo/odoo#44773 X-original-commit: d0d5172 Signed-off-by: oco-odoo <[email protected]>
Make sure `force_company` context key is set on the SO in all cases. Indeed, when the context key is not properly set, an incorrect fiscal position can be retrieved in: https://github.com/odoo/odoo/blob/cc557f1e4de88466d0d159c5edf1a606a0c0bc6f/addons/account/models/partner.py#L99-L100 This is for example the case when we go through the route `/shop/confirm_order`. opw-2186682 closes odoo/odoo#44451 closes odoo/odoo#44478 Signed-off-by: Toufik Benjaa (tbe) <[email protected]> Signed-off-by: Nicolas Martinelli (nim) <[email protected]>
closes odoo/odoo#44731 X-original-commit: 3530f03 Signed-off-by: Denis Ledoux (dle) <[email protected]>
- Go to Settings > Technical > Resource > Working Times - Have a Resource Calendar RC with Average hour per day != 8.00 - Have an Employee E with Working Hours == RC - Leaves > Configuration > Leave Types - Have a Leave Type LT with Take Leaves in Hours - Leaves > Managers > All > Allocations - Create an Allocation A with Employee E and Leave Type LT - Enter any number in Duration The number of hours entered changes as we leave the field. Being totally honest, what happens here is not clear at all, but using the corresponding `resource_id.calendar_id` field seems to fix the problem. opw-2191795 closes odoo/odoo#44880 Signed-off-by: Nicolas Martinelli (nim) <[email protected]>
- Set 'Product Unit of Measure' to 5 - Set the UoM rounding to 0.001 - Create an excluded tax of 6 % - Create a product costing 7.0 - Open the POS, add the product with a quantity of 0.535 The tax is 0.22 instead of 0.23. The root cause of the issue is the in JS: ``` round_pr(0.535, Math.pow(10,-5)) * 7 = 3.744999999999999 round_pr(0.535, 0.00001) * 7 = 3.745 ``` The numerical error impacts the tax computation later on. As a workaround, we round by the maximum between the UoM rounding and the 'Product Unit of Measure', which is what will be done in the backend anyway. opw-2205092 closes odoo/odoo#47346 X-original-commit: 125cdf9 Signed-off-by: Nicolas Martinelli (nim) <[email protected]>
- create product comp1 - create product finished1 - created bom: 1 comp1 for 1 finished1 - activate PBM - 100 units of comp1 in stock - create an MO for 5 - on the pbm, deliver 3 and no backorder - on the mo, check availability, produce 3 - on the pbm, unlock, change delivered qty from 3 to 5 On the mo, the raw move is reserved to 5 units but the 3 units used in the first produce are removed. It happens because editing the quantity or initial on a move will try to reserve the next moves. In order to reserved, _do_unreserve will destroy the stock.move.line and _action_assign (call just after) will recreate them in order to regenerate the reservation. In the process the qty_done on the stock.move.line will be loss. We want to avoid this behavior in mrp so we call _decrease_reserved_quantity from mrp that will keep stock.move.line with quantity done. opw-2206472 closes odoo/odoo#47375 X-original-commit: bc3af71 Signed-off-by: Arnold Moyaux <[email protected]>
…client Steps to reproduce the bug: - Let's consider a supplier S - Create two vendor bills for S: B1 for an amount A1 and B2 for an amount A2 - In the list view of vendor bills select B1 and B2 - In the action, select "Register a payment" and untick "group invoices" - Register the payments Bug: The partner_id in the wizard was False instead of S Fine tuning of 9393ea1 opw:2213559 closes odoo/odoo#47361 Signed-off-by: Simon Goffin (sig) <[email protected]>
Indicators were hidden in editor when switching to slideshow mode from any other mode. Because the class of the selected mode was defined after rendering and we need this class before the rendering. This also fixes other small issues when switching between different modes. Part of odoo/odoo#44180 task-2162952 X-original-commit: 7bae107
Before that the space between the first two links was more spaced than the others. Part of odoo/odoo#44180 task-2162952 closes odoo/odoo#47376 X-original-commit: d3f5b71 Signed-off-by: Quentin Smetz (qsm) <[email protected]>
With l10n_mx installed: - Check in the settings that cash basis option is activated, and enabled on a Purchase Tax (example : IVA(16%) COMPRAS) - Create a vendor bill with this tax, validate it and register payment. - Create a credit note to this invoice, validate and register payment. - Cancel the credit note Error will occur, a record is already deleted. This occur because the canceling action recursively find every related move to delete, but in the process an account.full.reconcile is going to be unlinked twice: a check on reverse the exchange rate entry will trigger the error because the record is already deleted opw-2199093 closes odoo/odoo#47341 Signed-off-by: Nicolas Martinelli (nim) <[email protected]>
(+ gallery snippet in carousel mode) Part of odoo/odoo#44180 task-2162952 X-original-commit: e3afe25
When the button print invoice has been removed, some behavior have not been correctly cleard. It lead to always display the message "The order has been synchronized", even if there are no invoiced, and there are no problems. It also lead to print this message to all receipt when button "Print receipt" is clicked. related commit: odoo/odoo@f55349f OPW-2214256
When your point of sale is offline and you try to print your ticket from the button 'Print Receipt', the notification "trying to reconnect" is displayed on the ticket. We are removing it when it is printed. closes odoo/odoo#47418 Signed-off-by: pimodoo <[email protected]>
Before this commit:
- Install some random module that can be uninstalled (so not base)
- Open the uninstall wizard for said module in two different tabs /
windows / whatever
- In one tab, confirm the module uninstall and wait for it to be
done
- As soon as the other tab is done with the uninstall, go to the
second one with the uninstall wizard still open, and proceed
with the second uninstall
- Boom, the registry crashes and completely fucks up the DB because
there's no check at all that prevents the uninstall of already
uninstalled modules.
After this commit:
- `ir.module.module.button_uninstall` will check if all the
modules being uninstalled are in the installed state
and if not a UserError will be raised, preventing a second
uninstall of the module which could potentially break the DB
Do note that this fix is LOCAL, the problem is however more or less
global, wherever there's user-actionable buttons that should only be
pressed once there's a potential for bugs / breakage if a similar fix is
not implemented locally. Perhaps a more global fix should be implemented
eventually, but it's generally less annoying for business cases since
those probably won't break the registry, see task 1859014.
opw-2213679
opw-2212594
opw-2206446
closes odoo/odoo#47443
X-original-commit: 8c1bb22
Signed-off-by: Adrian Torres (adt) <[email protected]>
before this commit: if groupable attribute is false on view and action has default groupby then view is rendered in grouped, for example kanban view for document which groupable=false, but setting default group from studio makes it groupable and due to which it throws error, issue is from web views which considers group_by even if view is non groupable. after this commit: if view is not groupable then even if default group_by passed from action of default_group_by attribute is set on kanban view,view will not be grouped view, it will always display normal view i.e. non grouped view task-1969134 closes odoo/odoo#45906 Signed-off-by: Damien Bouvy (dbo) <[email protected]>
Before this commit:
- Install a module
- Uninstall the previously installed module
- The registry will complain that some dependencies may be missing
for the module being uninstalled
This happens because we check after the installation / upgrade of
modules that none have been left in a transient state to verify that new
dependencies have been properly installed and loaded, this applies to
'to install' and 'to upgrade' states however it's not the same for 'to
remove' states, as the process of uninstall happens much later in the
code.
After this commit, simply uninstalling modules will not trigger this
error log.
Do note that in case of a problem with an uninstall, the function
"reset_module_states" will tackle the case of leftover transient states.
closes odoo/odoo#47463
Signed-off-by: Xavier Dollé (xdo) <[email protected]>
Steps to reproduce the bug: - Let's consider a supplier S - Create two vendor bills for S: B1 for an amount A1 and B2 for an amount A2 - In the list view of vendor bills select B1 and B2 - In the action, select "Register a payment" and tick "group invoices" - Register the payments Bug: The amount A1 + A2 of the regestering payment was not editable even if only one payment was needed. Fine tuning of this commit: 9393ea1 opw:2213576,2214516 closes odoo/odoo#47493 Signed-off-by: Simon Goffin (sig) <[email protected]>
Since 11 June 2018, enabling Billing on your Google Project used for showing static maps is required. So you would follow the only direction of Odoo "Create a Google Project and Get a Key" and nothing would work since you still need to enable billing. With this changeset, we add a link to the Google page explaining maps billing costs, current free usage tier and so on. And on this page the "Get started" button will enable billing if needed. There is another page with deeper explanation but it is very technical and currently only available in english: https://developers.google.com/maps/gmp-get-started note: also improve text of has_google_maps option opw-2210346 closes #47227 closes odoo/odoo#47433 X-original-commit: d0251579c10ea20bb3eec409dc2f689d11009457 Signed-off-by: Nicolas Lempereur (nle) <[email protected]>
On the website for portal and public users, we only show membership products that are set as website_published. But if you only install eg. website_membership there is no clear way through "Members" > "Configuration" | "Membership Products" to set product as website_published. opw-2202766 closes #47342 closes odoo/odoo#47423 X-original-commit: 028f664 Signed-off-by: Nicolas Lempereur (nle) <[email protected]>
The synchronisation of commercial_partner_id was introduced at 0d68acf as a way to ensure the value is always correct. The order or the operation was not important though. This synchronisation has a side effect in the following scenario: 0. install base_vat 1. disable vat_check_vies in the settings 2. set an invalid VAT number on a company with at least one contact 3. enable vat_check_vies in the settings 4. correct the VAT number on the company with a valid one --> an error was raised for an invalid VAT number on the contact This is because the commercial_partner_id synchronisation is done before the update of the VAT number. Even if the value has not changed, this triggers the check_vat method. Invert both instructions Courtesy of Wolfgang Taferner Closes odoo/odoo#43065 Closes odoo/odoo#42973 closes odoo/odoo#47524 X-original-commit: d9b2605 Signed-off-by: Martin Trigaux (mat) <[email protected]>
Before this commit, when a product switched to type `service`, the service invoicing policy was left as empty value This commit fix this problem. The default value will be "Ordered quantities" (ordered_timesheet) closes odoo/odoo#46817 Taskid: 2205594 Signed-off-by: Yannick Tivisse (yti) <[email protected]>
…41cc6ab92 No conflicts
Member
|
The same about the diff on noupdate file. |
MiquelRForgeFlow
force-pushed
the
12.0-update-upstream-1341cc6ab92
branch
from
c764708 to
1c5df4a
Compare
Member
|
I suppose there's no diff now in noupdate, isn't it? |
Contributor
Author
Exactly 😅 |
Member
|
/ocabot merge |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at a290ac1. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated.
No conflicts.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr