Skip to content

Conversation

@MiquelRForgeFlow
Copy link
Contributor

I wanted to do it several days ago, and now I make it before going to lunch =P

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@pedrobaeza
Copy link
Member

Shouldn't this be on stock module instead?

@MiquelRForgeFlow
Copy link
Contributor Author

Why? It just happens it's only one table, related to stock, but there could be more tables and ones unrelated to stock. If in the future we want to add more tables, for example, many2many tables, then it will be easy to add them in this method instead of add again the method. It's the same done in 565ab92, that later was filled with ddb89a8.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there are 2 conflicting goals here:

  • Have all obsolete models in the same place.
  • Reduce noise in the log. I'm analyzing the openupgradelib method and indeed there's no noise if the module is not installed, so OK to put it here.

@pedrobaeza pedrobaeza merged commit d607b67 into OCA:12.0 Mar 25, 2020
@MiquelRForgeFlow MiquelRForgeFlow deleted the 12.0-fix-base-add-remove_tables_fks branch March 25, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants