[FIX] website: handle dangling root menus #2311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Migration script is not correct. |
We could find in a DB a dangling root menu that was not being used. After migration, that menu became website's menu, breaking menu layout. To avoid that problem, make sure that any website-specific-but-unused root menu is transformed to website-agnostic, so the main website menu selected by `env['website']._compute_menu()` is definitely the menu we create later in this function. @Tecnativa TT23336
yajo
force-pushed
the
12.0-website-fix_dangling_website_specific_menus
branch
from
cbd4ce8 to
ad3d3da
Compare
pedrobaeza
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could find in a DB a dangling root menu that was not being used.
After migration, that menu became website's menu, breaking menu layout.
To avoid that problem, make sure that any website-specific-but-unused root menu is transformed to website-agnostic, so the main website menu selected by
env['website']._compute_menu()is definitely the menu we create later in this function.@Tecnativa TT23336