[FIX] mail: remove admin from mail.alias #2350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
force-pushed
the
12.0-mail_alias_fix_admin_owner
branch
from
b018aba to
9a4393c
Compare
Member
|
@StefanRijnhart you did this part. Can you please check? |
Member
|
I don't understand why you say that the Administrator is not going to be used anymore. I believe it is, but its privileges will now be based on group membership instead of having a magic ID (that is the prerogative of the inactive root user). |
When a mail.alias record belongs to admin, it will try to send mails in name of a user that most likely has wrong data in it, and is actually garbage. That can produce a problem where aliases create records but don't notify followers, or even worse, that same problem in loop (depending possibly on if you use IMAP4 or POP3 to fetch mails). @Tecnativa TT24347
yajo
force-pushed
the
12.0-mail_alias_fix_admin_owner
branch
from
9a4393c to
93f3717
Compare
Member
Author
|
All solved. |
yajo
changed the title
ivantodorovich
approved these changes
Jun 16, 2020
StefanRijnhart
approved these changes
Jun 16, 2020
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks for the update!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Administrator is not going to be used anymore, it is best to archive that partner, just like it is done with that user. If not doing so, accessing the user will display a warning about this.When a mail.alias record belongs to admin, it will try to send mails in name of a user that most likely has wrong data in it, and is actually garbage. That can produce a problem where aliases create records but don't notify followers, or even worse, that same problem in loop (depending possibly on if you use IMAP4 or POP3 to fetch mails).
@Tecnativa TT24347