[13.0][FIX] fix migration with product with twice the same attribute #2488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienbeau
force-pushed
the
13.0-fix-product-migration
branch
from
8cd8f6c to
92cb03d
Compare
|
Hi, @sebastienbeau. |
Member
|
Yeah, that my same question: how do you get to that incorrect configuration? |
Member
Author
|
In my case, the data was coming from version 8, so it was possible in V8. |
Contributor
|
If two product variants have the same attributes, then we should merge those variants into one record. |
sbidoul
changed the title
Contributor
|
As I commented before about merging variants, I have done a PR with that approach, which I think is better. Please, could you check #2513? |
|
HI, @sebastienbeau. Could you confirm that #2513 fixed or not your problem? |
|
@sebastienbeau Any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
For some product you can have twice the same attribute
Example you have a bi-color product you can set
attribute line 1: color => white, black, yellow
attribute line 2: color => green, blue, yellow
if both attribute line have same value for the color it's a litle more
complexe to fill the value as you have two product_template_attribute_value
with the same attribute_value "yellow"
Current behavior before PR:
Migration fail
Desired behavior after PR is merged:
Migration work
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr