Skip to content

[13.0][IMP] openupgrade_framework: remove FKs of obsolete tables/columns #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiquelRForgeFlow wants to merge 1 commit into
base: 13.0
Choose a base branch
from
Open

[13.0][IMP] openupgrade_framework: remove FKs of obsolete tables/columns #2990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions odoo/addons/base/models/ir_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
from odoo.tools import pycompat
from odoo.tools.safe_eval import safe_eval

from odoo.openupgrade import openupgrade_log, openupgrade_loading
from openupgradelib import openupgrade

_logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -191,12 +190,14 @@ def _drop_table(self):
for model in self:
current_model = self.env.get(model.model)
if current_model is not None:
# OpenUpgrade: do not run the new table cleanup
# OpenUpgrade: do not drop the table
table = current_model._table
if tools.table_kind(self._cr, table) == "r":
openupgrade.remove_tables_fks(self.env.cr, [table])
openupgrade.message(
self._cr, 'Unknown', False, False,
"Not dropping the table or view of model %s", model.model)
continue
table = current_model._table
kind = tools.table_kind(self._cr, table)
if kind == 'v':
self._cr.execute('DROP VIEW "%s"' % table)
Expand Down Expand Up @@ -615,13 +616,21 @@ def _drop_column(self):
if field.name in models.MAGIC_COLUMNS:
continue
# OpenUpgrade: do not drop columns
model = self.env.get(field.model)
if (
field.store
and field.ttype == "many2one"
and model is not None
and tools.column_exists(self._cr, model._table, field.name)
and tools.table_kind(self._cr, model._table) == "r"
):
openupgrade.lift_constraints(self.env.cr, model._table, field.name)
openupgrade.message(
self._cr, 'Unknown', False, False,
"Not dropping the column of field %s of model %s", field.name,
field.model,
)
continue
model = self.env.get(field.model)
is_model = model is not None
if field.store:
# TODO: Refactor this brol in master
Expand Down