[MIG] Bootstrapping 16.0 + analysis #3583

StefanRijnhart · 2022-10-06T10:26:45Z

Continued from #3582, after rebuilding the 16.0 branch without docs, openupgrade_framework and the scripts from openupgrade_scripts.

Added some documentation to https://github.com/OCA/OpenUpgrade/wiki/Set-up-the-branch-for-a-new-Odoo-release.

Also slightly updated:

StefanRijnhart · 2022-10-06T10:46:25Z

@pedrobaeza thanks for challenging the branch setup. Nothing that could not be fixed with a

git format-patch --keep-subject --stdout origin/16.0..origin/15.0 -- \
    ':!docs' ':!openupgrade_scripts/scripts' \
    ':!openupgrade_framework' \
    ':!docsource/modules140-150.rst' \
    ':!openupgrade_scripts/apriori.py' \
| git am -3 --

And look at that clean history: https://github.com/OCA/Openupgrade/commits/16.0

StefanRijnhart · 2022-10-06T10:47:34Z

~~The test CI job fails without openupgrade_framework, or any scripts for that matter.~~ fixed by not running the test migration if no modules are ready yet.

pedrobaeza · 2022-10-19T18:28:19Z

openupgrade_scripts/apriori.py

+}
+
+# only used here for upgrade_analysis
+renamed_models = {


The analysis has to be re-run if renamed models are found. Do you know if there's any right now?

No, not aware of any.

The re-run will have to be done few months later, anyway.

pedrobaeza · 2022-10-19T18:29:07Z

openupgrade_scripts/README.rst

-.. |badge3| image:: https://img.shields.io/badge/github-OCA%2FOpenUpgrade-lightgray.png?logo=github
-    :target: https://github.com/OCA/OpenUpgrade/tree/16.0/openupgrade_scripts
-    :alt: OCA/OpenUpgrade
+.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fopenupgrade-lightgray.png?logo=github


Why changing uppercase?

Oh I did not pay any attention to the casing when I ran oca-gen-addon-readme. I didn't know it mattered, and I'm still slightly annoyed the project name has to be passed on the command line 😛

It's for reducing the diff essentially, and yes, you need to introduce it, as it can't be deduced from the folder itself.

Couldn't we introduce a .oca-project-name file in the root of the addons directory?

That's a good idea, but it should be proposed at maintainer-tools, and maybe harmonize it with ocaport hidden directory (not sure if it's .oca), and also bootstrap it through the copier template.

Feyensv

Only curiously looking at the analysis of the modules in my team's scope :3
Giving some information on the way to help the upgrades ;).

(really nice work to detect all those changes automatically, it's a great tool 👍)

Feyensv · 2022-10-20T11:09:49Z

openupgrade_scripts/scripts/payment/16.0.2.0/upgrade_analysis.txt

+obsolete model payment.acquirer
+obsolete model payment.acquirer.onboarding.wizard [transient]
+model payment.refund.wizard (moved to account_payment) [transient]
+new model payment.provider
+new model payment.provider.onboarding.wizard [transient]


FYI those two changes are model rename (acquirer -> provider)
will probably simplify the upgrade analysis ;)

(Applies to view & other records xml ids as well, in payment(_*) modules, we replaced all occurrences of acquirer)

Feyensv · 2022-10-20T11:14:45Z

openupgrade_scripts/scripts/sale/16.0.1.2/upgrade_analysis.txt

+obsolete model sale.payment.acquirer.onboarding.wizard [transient]
+new model sale.payment.provider.onboarding.wizard [transient]


model renaming

pedrobaeza · 2022-10-20T11:45:07Z

Thank you for taking a look, Victor!

@StefanRijnhart it seems we have our first renamed models to include and re-run analysis.

jcdrubay · 2022-10-26T03:00:53Z

Hi,

Is there anything blocking that PR?
Wouldn't it be possible to merge and later on improve after re-running analysis and have a more iterative approach?

I have updated https://oca-cm-15.komit.link to take into account v16.0 and currently it does not reflect the real situation without this PR being merged.

StefanRijnhart · 2022-10-26T08:29:35Z

Please merge this and someone can follow up with a new analysis. My computer is still smoking from all the analysis runs I did for this PR.

pedrobaeza · 2022-10-26T10:14:23Z

OK, merging blindly

pedrobaeza · 2022-10-26T10:15:10Z

The model renamings mentioned by Victor are still pending.

StefanRijnhart added the work in progress label Oct 6, 2022

StefanRijnhart changed the title ~~[MIG] Bootstrapping 16.0 + analysis~~ [WIP] [MIG] Bootstrapping 16.0 + analysis Oct 6, 2022

StefanRijnhart marked this pull request as draft October 6, 2022 10:29

StefanRijnhart force-pushed the 16.0 branch from cb76d2a to c92c41d Compare October 6, 2022 10:33

StefanRijnhart added 3 commits October 6, 2022 12:34

[MIG] Clean apriori

02ec4f7

[MIG] 16.0: adapt version numbers

e10af58

[MIG] openupgrade_scripts version number

f48ec23

StefanRijnhart force-pushed the mig/16.0/infra branch from 1e2e8c5 to 971a8bb Compare October 6, 2022 10:35

StefanRijnhart marked this pull request as ready for review October 6, 2022 10:46

StefanRijnhart removed the work in progress label Oct 6, 2022

StefanRijnhart changed the title ~~[WIP] [MIG] Bootstrapping 16.0 + analysis~~ [MIG] Bootstrapping 16.0 + analysis Oct 6, 2022

StefanRijnhart mentioned this pull request Oct 10, 2022

Infrastructure migration to 16.0 #3580

Closed

4 tasks

StefanRijnhart force-pushed the mig/16.0/infra branch 3 times, most recently from 13efb88 to 1e3255b Compare October 11, 2022 09:31

legalsylvain added this to the 16.0 milestone Oct 11, 2022

StefanRijnhart added 4 commits October 11, 2022 17:14

[ADD] 16.0 Analysis

a060a76

[MIG] Documentation sources

87a301b

[MIG] Github workflows

9b58ca8

[FIX] Don't fail test job if no modules are covered yet

1999340

StefanRijnhart force-pushed the mig/16.0/infra branch from 1e3255b to 1999340 Compare October 11, 2022 15:15

StefanRijnhart mentioned this pull request Oct 12, 2022

[15.0][FIX] upgrade_analysis: misleading representation of read/write computed fields OCA/server-tools#2416

Merged

MiquelRForgeFlow approved these changes Oct 19, 2022

View reviewed changes

pedrobaeza reviewed Oct 19, 2022

View reviewed changes

Feyensv reviewed Oct 20, 2022

View reviewed changes

pedrobaeza merged commit 4263532 into OCA:16.0 Oct 26, 2022

pedrobaeza mentioned this pull request Nov 7, 2022

Update our tooling to support Odoo 16.0 OCA/maintainer-tools#537

Closed

22 tasks

		obsolete model sale.payment.acquirer.onboarding.wizard [transient]
		new model sale.payment.provider.onboarding.wizard [transient]

Uh oh!

[MIG] Bootstrapping 16.0 + analysis #3583

[MIG] Bootstrapping 16.0 + analysis #3583

Uh oh!

Conversation

StefanRijnhart commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefanRijnhart commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefanRijnhart commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Feyensv left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Oct 20, 2022

Uh oh!

jcdrubay commented Oct 26, 2022

Uh oh!

StefanRijnhart commented Oct 26, 2022

Uh oh!

pedrobaeza commented Oct 26, 2022

Uh oh!

pedrobaeza commented Oct 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

StefanRijnhart commented Oct 6, 2022 •

edited

Loading

StefanRijnhart commented Oct 6, 2022 •

edited

Loading

StefanRijnhart commented Oct 6, 2022 •

edited

Loading