-
-
Notifications
You must be signed in to change notification settings - Fork 785
[16.0] [OU-ADD] crm #3765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [OU-ADD] crm #3765
Conversation
10d69ca to
bd67eaa
Compare
|
/ocabot migration crm |
bd67eaa to
0625e9f
Compare
835f698 to
bc8cb53
Compare
remytms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
||
| @openupgrade.migrate() | ||
| def migrate(env, version): | ||
| openupgrade.rename_columns(env.cr, _column_renames) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think It should be
| openupgrade.rename_columns(env.cr, _column_renames) | |
| openupgrade.rename_fields(env, _column_renames) |
to support translation also although the openupgrade lib not support yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, done
bc8cb53 to
5b52e09
Compare
|
This PR has the |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at c05a637. Thanks a lot for contributing to OCA. ❤️ |
No description provided.