Skip to content

Conversation

@marielejeune
Copy link

No description provided.

@sbidoul
Copy link
Member

sbidoul commented Mar 15, 2023

/ocabot migration portal

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 15, 2023
@marielejeune marielejeune force-pushed the 16.0-portal-mle branch 2 times, most recently from ff35dcd to 470f0d5 Compare March 27, 2023 14:39
@marielejeune marielejeune changed the title [16.0][MIG] portal: Nothing to do [16.0][OU-ADD] portal: Nothing to do Apr 6, 2023
legalsylvain

This comment was marked as duplicate.

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marielejeune. Thanks for your contribution.

I see that there is a noupdate_changes.xml file for that module, with a mail template. I guess that we should write a post-migration script to refresh the data. don't you think ?

See according new documentation : https://oca.github.io/OpenUpgrade/use_cases/noupdate_xml_entry_changed.html#write-migration-script

@marielejeune
Copy link
Author

I see that there is a noupdate_changes.xml file for that module, with a mail template. I guess that we should write a post-migration script to refresh the data. don't you think ?

Right, done

@marielejeune marielejeune changed the title [16.0][OU-ADD] portal: Nothing to do [16.0][OU-ADD] portal Jul 3, 2023
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3782-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 78c301d into OCA:16.0 Jul 3, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 78c301d. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Member

@legalsylvain this one is still missing to delete the record translations.

@legalsylvain
Copy link
Contributor

@legalsylvain this one is still missing to delete the record translations.

Hum. That's annoying. I'd like to integrate the deletion of the translation in load_data, if version >= 16.0 this should avoid that noicy second line, that is mandatory in most case. What do you think ?

@pedrobaeza
Copy link
Member

I'm afraid that's not so easy to be done and will require to patch Odoo itself, but if got, it would be great of course. But meanwhile, we need to complete the scripts with current system.

@legalsylvain
Copy link
Contributor

I'm afraid that's not so easy to be done and will require to patch Odoo itself, but if got, it would be great of course.

Yes, I thought to this point, and it doesn't seems easy indeed.

But meanwhile, we need to complete the scripts with current system.

@marielejeune could you provide a PR ?

@marielejeune
Copy link
Author

@legalsylvain Done here: #4028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants