-
-
Notifications
You must be signed in to change notification settings - Fork 785
[16.0][OU-ADD] portal #3782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][OU-ADD] portal #3782
Conversation
|
/ocabot migration portal |
ff35dcd to
470f0d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @marielejeune. Thanks for your contribution.
I see that there is a noupdate_changes.xml file for that module, with a mail template. I guess that we should write a post-migration script to refresh the data. don't you think ?
See according new documentation : https://oca.github.io/OpenUpgrade/use_cases/noupdate_xml_entry_changed.html#write-migration-script
470f0d5 to
f50e18e
Compare
Right, done |
legalsylvain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 78c301d. Thanks a lot for contributing to OCA. ❤️ |
|
@legalsylvain this one is still missing to delete the record translations. |
Hum. That's annoying. I'd like to integrate the deletion of the translation in load_data, if version >= 16.0 this should avoid that noicy second line, that is mandatory in most case. What do you think ? |
|
I'm afraid that's not so easy to be done and will require to patch Odoo itself, but if got, it would be great of course. But meanwhile, we need to complete the scripts with current system. |
Yes, I thought to this point, and it doesn't seems easy indeed.
@marielejeune could you provide a PR ? |
|
@legalsylvain Done here: #4028 |
No description provided.