Skip to content

Conversation

@SonCrits
Copy link

@SonCrits SonCrits commented Jul 3, 2023

Migration data

@legalsylvain
Copy link
Contributor

legalsylvain commented Jul 3, 2023

/ocabot migration project

@SonCrits SonCrits force-pushed the v16_add_project_1 branch from 017f5bc to ad6a834 Compare July 13, 2023 02:18
@SonCrits SonCrits force-pushed the v16_add_project_1 branch 2 times, most recently from 4884dce to a1b0788 Compare July 17, 2023 07:46
@SonCrits SonCrits force-pushed the v16_add_project_1 branch from a1b0788 to 190da0a Compare July 19, 2023 01:40
@legalsylvain
Copy link
Contributor

Hi @SonCrits. There is a conflict, and unrelated commits. Could you rebase ?
thanks !

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from the need for rebase @legalsylvain asked, I also see that you defined a _fill_proejct_allow_milestones(yes with the typo) and you didn't call it anywhere.
I believe it should be called to fill the new allow_milestones field.

@legalsylvain
Copy link
Contributor

Hi @SonCrits.
Do you think you'll finish this work ?

thanks !

@SonCrits
Copy link
Author

Hi @SonCrits. Do you think you'll finish this work ?

thanks !

i'm sorry

@SonCrits SonCrits closed this Jan 17, 2024
@remytms
Copy link

remytms commented Jan 19, 2024

If I understand, this PR is abandoned. I will take it back. :)

@remytms
Copy link

remytms commented Feb 7, 2024

Replaced by #4289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.