Skip to content

[16.0][OU-ADD] sale_timesheet: Migration scripts #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hoangtiendung070797 wants to merge 1 commit into from
Closed

[16.0][OU-ADD] sale_timesheet: Migration scripts #4020

hoangtiendung070797 wants to merge 1 commit into from

Conversation

@hoangtiendung070797
Copy link

@hoangtiendung070797 hoangtiendung070797 commented Jul 4, 2023

No description provided.

@legalsylvain
Copy link
Contributor

legalsylvain commented Jul 4, 2023 •
edited
Loading

/ocabot migration sale_timesheet

Depends on :

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 4, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 4, 2023
Open
@legalsylvain legalsylvain mentioned this pull request Jul 8, 2023
Closed
robinkeunen
robinkeunen approved these changes Feb 8, 2024
View reviewed changes
Copy link

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

remytms
remytms approved these changes Feb 8, 2024
View reviewed changes
Copy link

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe commit and title of PR should be renamed to:
[OU-ADD] sale_timesheet: done
As there is something that done.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 8, 2024

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

remi-filament
remi-filament suggested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@remi-filament remi-filament left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @hoangtiendung070797
I think the PR name and commit messages are misleading as you are not doing nothing in this PR !
Best Regards,

openupgrade_scripts/scripts/sale_timesheet/16.0.1.0/pre-migration.py

@openupgrade.migrate()
def migrate(env, version):
_update_account_analytic_line_timesheet_invoice_type(env)
Copy link
Contributor

@remi-filament remi-filament Feb 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hoangtiendung070797
as per #4313 you may want to also drop view project_profitability_report :

Suggested change
_update_account_analytic_line_timesheet_invoice_type(env)
_update_account_analytic_line_timesheet_invoice_type(env)
# Remove SQL view project_profitability_report not used anymore in Odoo v16.0
openupgrade.logged_query(
env.cr, "DROP VIEW IF EXISTS project_profitability_report CASCADE"
)

@pedrobaeza pedrobaeza changed the title [16.0][OU-ADD] sale_timesheet: nothing to do [16.0][OU-ADD] sale_timesheet: Migration scripts Mar 10, 2024
@pedrobaeza pedrobaeza mentioned this pull request Mar 10, 2024
Merged
@pedrobaeza
Copy link
Member

pedrobaeza commented Mar 10, 2024

Superseded by #4345

@pedrobaeza pedrobaeza closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@remi-filament remi-filament remi-filament requested changes

@robinkeunen robinkeunen robinkeunen approved these changes

@remytms remytms remytms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Dependency OK

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

7 participants

@hoangtiendung070797 @legalsylvain @OCA-git-bot @pedrobaeza @robinkeunen @remytms @remi-filament