Skip to content

[16.0][OU-ADD] website_crm: Nothing to do #4176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pedrobaeza merged 1 commit into from
Feb 12, 2024
Merged

[16.0][OU-ADD] website_crm: Nothing to do #4176

pedrobaeza merged 1 commit into from
Feb 12, 2024

Conversation

@victoralmau
Copy link
Member

@victoralmau victoralmau commented Oct 18, 2023 •
edited by legalsylvain
Loading

Nothing to do

Depends on:

@Tecnativa TT43628

@legalsylvain
Copy link
Contributor

legalsylvain commented Oct 18, 2023 •
edited
Loading

/ocabot migration website_crm

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 18, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 18, 2023
Open
marielejeune
marielejeune approved these changes Nov 24, 2023
View reviewed changes
Copy link

@marielejeune marielejeune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

robinkeunen
robinkeunen approved these changes Jan 12, 2024
View reviewed changes
Copy link

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to do, LGTM 👌

@robinkeunen
Copy link

robinkeunen commented Jan 12, 2024

A rebase after the merge of #3949 should fix the tests.

@legalsylvain
Copy link
Contributor

legalsylvain commented Jan 12, 2024

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 12, 2024

@legalsylvain The rebase process failed, because command git push --force Tecnativa tmp-pr-4176:16.0-mig-website_crm failed with output:

remote: Permission to Tecnativa/OpenUpgrade.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/Tecnativa/OpenUpgrade/': The requested URL returned error: 403

@victoralmau
Copy link
Member Author

victoralmau commented Feb 12, 2024

Rebase done.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 12, 2024

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit cdb961e into OCA:16.0 Feb 12, 2024
@pedrobaeza pedrobaeza deleted the 16.0-mig-website_crm branch February 12, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

+2 more reviewers

@robinkeunen robinkeunen robinkeunen approved these changes

@marielejeune marielejeune marielejeune approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Dependency OK ready to merge

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

6 participants

@victoralmau @legalsylvain @robinkeunen @OCA-git-bot @pedrobaeza @marielejeune