[16.0][OU-ADD] sale_expense: apply noupdate changes #4292
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victoralmau
approved these changes
Feb 12, 2024
Contributor
|
This PR has the |
|
merge? |
pedrobaeza
changed the title
Member
|
I think it's too risky to change the policies of the existing products. It's OK to have that new defaults in a fresh v16 DB, but not to switch them when coming from v15, as they will behave different when migrating. Please comment the content on the noupdate_changes.xml file including these reflections. |
|
Hi @robinkeunen, do you plan to apply Pedro's suggestion? |
Author
|
@marielejeune I won't have time in April. Feel free to superseed. |
Member
|
Superseded by #4411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superseeds #4030
Blocked by dependency