Skip to content

[17.0][FIX] define openupgradelib git url in test-requirements.txt #4322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 2 commits into from
Feb 28, 2024
Merged

[17.0][FIX] define openupgradelib git url in test-requirements.txt #4322

OCA-git-bot merged 2 commits into from
Feb 28, 2024

Conversation

@legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Feb 27, 2024

Ref : #4294

pedrobaeza
pedrobaeza reviewed Feb 28, 2024
View reviewed changes
openupgrade_scripts/README.rst Outdated
:target: https://github.com/OCA/OpenUpgrade/tree/17.0/openupgrade_scripts
:alt: OCA/OpenUpgrade
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fopenupgrade-lightgray.png?logo=github
:target: https://github.com/OCA/openupgrade/tree/17.0/openupgrade_scripts
Copy link
Member

@pedrobaeza pedrobaeza Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change in casing? It was correct before

Copy link
Contributor Author

@legalsylvain legalsylvain Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do that. Pre-commit did it.
Something should be wrong in readme generation.

I'll take a look.

Copy link
Member

@pedrobaeza pedrobaeza Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the folder where you download this is in lower case?

Copy link
Contributor Author

@legalsylvain legalsylvain Feb 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the folder where you download this is in lower case?

renamed into Camelcase, and doesn't change anything.

Copy link
Member

@pedrobaeza pedrobaeza Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is the problem:

OpenUpgrade/.copier-answers.yml

Line 20 in 843d412

repo_slug: openupgrade

@pedrobaeza pedrobaeza changed the title [FIX] define openupgradelib git url in test-requirements.txt [17.0][FIX] define openupgradelib git url in test-requirements.txt Feb 28, 2024
@legalsylvain legalsylvain force-pushed the 17.0-FIX-openupgradelib-dependency branch from ff23148 to d68a96b Compare February 28, 2024 09:54
@legalsylvain legalsylvain added this to the 17.0 milestone Feb 28, 2024
@legalsylvain
Copy link
Contributor Author

legalsylvain commented Feb 28, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 28, 2024

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-4322-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9e94f02 into OCA:17.0 Feb 28, 2024
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 28, 2024

Congratulations, your PR was merged at be57432. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@StefanRijnhart StefanRijnhart Awaiting requested review from StefanRijnhart

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.

3 participants

@legalsylvain @OCA-git-bot @pedrobaeza