[16.0][OU-ADD] delivery: Migration scripts #4370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Member
Author
|
/ocabot migration delivery |
The other algorithm is not OK when dealing numeric ranges, as it also generates the prefixes for the rest of the alphanumeric values, when it's clear that we are not wanting such cases (although previous v15 string comparison allowed it without intent). TT43606
pedrobaeza
force-pushed
the
16.0-ou_add-delivery
branch
from
62cf11f to
4fc2f4c
Compare
huguesdk
reviewed
Jan 21, 2025
Member
huguesdk
left a comment
huguesdk
left a comment
There was a problem hiding this comment.
@pedrobaeza i encountered 2 issues with the numerical ranges:
- when a numerical zip code starts with a
0(which exists in some countries), this information is lost. - odoo converts all prefixes to capitals, and the prefixes returned by
numerical_range_to_prefixes()sometimes containr"\d"expressions, which becomer"\D"and thus don’t work.
Member
Author
|
Well, I haven't been in the need of such conversions for now, so feel free to propose improvements/exceptions on current scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #4112
@Tecnativa TT43606