[15.0][OU-FIX] hr_expense: Get payment_state directly #4448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous approach was too much aggressive, calling a very generic method that does a lot of stuff apart from recomputing payment_state, launching a rewrite of the lines with debit=0 and credit=0, which totally wrecks the accounting. Now we have extracted the code for computing the payment state inside the migration script and manually written for each of the expenses moves.
Member
Author
|
Tested on real migration. |
Member
|
this only sets the value of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous approach was too much aggressive, calling a very generic method that does a lot of stuff apart from recomputing payment_state, launching a rewrite of the lines with debit=0 and credit=0, which totally wrecks the accounting.
Now we have extracted the code for computing the payment state inside the migration script and manually written for each of the expenses moves.
@Tecnativa