[17.0][OU-ADD] hr_expense: migration to 17.0 #4472
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/ocabot migration hr_expense |
|
|
||
| @openupgrade.migrate() | ||
| def migrate(env, version): | ||
| openupgrade.load_data(env, "hr_expense", "17.0.2.0/noupdate_changes.xml") |
Contributor
There was a problem hiding this comment.
delete template translations
| # NOTHING TO DO: dead code https://github.com/odoo/odoo/pull/110518 | ||
|
|
||
| hr_expense / hr.expense / price_unit (float) : NEW required, isfunction: function, stored | ||
| # DONE pre-migration: rename to unit_price |
| # NOTHING TO DO: deprecated field https://github.com/odoo/odoo/pull/130244/commits/266b482264576903cf736ffe2bddfc71f7a7a4ec | ||
|
|
||
| hr_expense / hr.expense / state (selection) : selection_keys is now '['approved', 'done', 'draft', 'refused', 'reported', 'submitted']' ('['approved', 'done', 'draft', 'refused', 'reported']') | ||
| # DONE pre-migration: if any expense has expense sheet and the sheet is on draft state, then update state of expense to 'reported' |
Contributor
There was a problem hiding this comment.
why? the change only adds new 'submitted' state
Merged
Contributor
|
Superseded by #4826. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.