Skip to content

Conversation

@flachica
Copy link

No description provided.

@legalsylvain
Copy link
Contributor

legalsylvain commented Jun 26, 2024

/ocabot migration point_of_sale

@legalsylvain
Copy link
Contributor

thanks !

@MiquelRForgeFlow
Copy link
Contributor

could you elaborate

Migration is incomplete. I will try to expand it in the future. I put that tag to remind myself about that.

@legalsylvain
Copy link
Contributor

Migration is incomplete.

could you be more explicit and mention what is missing ? I think @flachica is interested to have a review.

Thanks !

@flachica flachica force-pushed the v17_ou_point_of_sale branch from 2c0b18d to d8a98fd Compare March 7, 2025 16:44
@flachica
Copy link
Author

flachica commented Mar 7, 2025

Rebase applied @legalsylvain but tests fails

@legalsylvain
Copy link
Contributor

legalsylvain commented Mar 7, 2025

Indeed.

there is some error in account migration. I don't understand why V17 branch is green, and this PR is red.

025-03-07 16:49:14,578 4304 ERROR openupgrade odoo.sql_db: bad query: INSERT INTO "ir_model_data" ("create_date", "create_uid", "model", "module", "name", "noupdate", "res_id", "write_date", "write_uid") VALUES ('2025-03-07 16:49:07.927963', 1, 'account.tax.group', 'l10n_eu_oss', '10_oss_tax_group_20_0_1aa1', true, 599, '2025-03-07 16:49:07.927963', 1) RETURNING "id"
ERROR: duplicate key value violates unique constraint "ir_model_data_module_name_uniq_index"
DETAIL:  Key (module, name)=(l10n_eu_oss, 10_oss_tax_group_20_0_1aa1) already exists.

@pedrobaeza, @hbrunn that's maybe related to d1c163a
could you take a look ?

thanks !

@MiquelRForgeFlow
Copy link
Contributor

I don't understand why V17 branch is green, and this PR is red.

Don't worry, sometimes happens. After re-running the CI job, like this case, is fixed.

@hbrunn
Copy link
Member

hbrunn commented Mar 10, 2025

I'm working on a once-and-for-all fix for this

@hbrunn
Copy link
Member

hbrunn commented Mar 10, 2025

#4806

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the v17_ou_point_of_sale branch 2 times, most recently from 927e9dc to b5b76af Compare March 20, 2025 19:05
@MiquelRForgeFlow MiquelRForgeFlow merged commit c5e84ee into OCA:17.0 Mar 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants