[15.0][OU-FIX] web: Set the correct report_footer value #4680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victoralmau
force-pushed
the
15.0-ou-fix-web-TT52003
branch
from
1cb167f to
a835914
Compare
pedrobaeza
requested changes
Nov 28, 2024
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
This is missing the decorations to be exactly as it was (<ul>, <li>, icons, etc).
Related to OCA#4095 TT52003
victoralmau
force-pushed
the
15.0-ou-fix-web-TT52003
branch
from
a835914 to
b69788a
Compare
Member
|
Have you checked that these classes are correctly exported to PDF? |
Member
Author
|
Yes, it is checked. Configure document layout wizard Pdf footer Still, I think an extra validation of this change would be nice (for example in a migration). |
Member
|
Great, let's test it in the migration we are going to perform, cc @chienandalu I'm merging now and possible amendments will be done through subsequent PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the correct report_footer value
Related to #4095
@Tecnativa TT52003