-
-
Notifications
You must be signed in to change notification settings - Fork 785
[17.0][OU-ADD] website_sale: Nothing to do #4687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
96d03d3 to
fecdb53
Compare
|
/ocabot migration website_sale |
hbrunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR should include merging website_sale_digital into website_sale and run the query @dansanti proposes in #4561 (comment)
Hello @hbrunn , Thank you for your suggestion. It is preferable to make a different PR for each module. The website_sale_digital script will be done later. Although it's always welcome if you prefer to do it yourself to get ahead of the work. Regards |
|
hi! @pilarvargas-tecnativa website_sale_digital was merged with website_sale please add this scripts: |
Hi @dansanti thanks for your work. I had already commented it with @hbrunn before but I reiterate my words, it's better to make a separate PR for each module. I take into account your suggestions to do it later but it's always welcome if someone wants to do that PR. My regards |
fecdb53 to
425d496
Compare
openupgrade_scripts/scripts/website_sale/17.0.1.1/upgrade_analysis_work.txt
Outdated
Show resolved
Hide resolved
425d496 to
1e66926
Compare
1e66926 to
3e62397
Compare
MiquelRForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
|
Hey, thanks for contributing! Proceeding to merge this for you. |
openupgrade_scripts/scripts/website_sale/17.0.1.1/post-migration.py
Outdated
Show resolved
Hide resolved
3e62397 to
1f87670
Compare
|
@MiquelRForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-4687-by-MiquelRForgeFlow-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 741f443. Thanks a lot for contributing to OCA. ❤️ |
|
@pilarvargas-tecnativa please do |
|
We don't need that module for now. |
|
website_sale_digital handled in #4879. |
cc @Tecnativa TT51563