Skip to content

Conversation

@pilarvargas-tecnativa
Copy link
Contributor

cc @Tecnativa TT51563

@legalsylvain
Copy link
Contributor

legalsylvain commented Dec 5, 2024

/ocabot migration website_sale

Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR should include merging website_sale_digital into website_sale and run the query @dansanti proposes in #4561 (comment)

@pilarvargas-tecnativa
Copy link
Contributor Author

I think this PR should include merging website_sale_digital into website_sale and run the query @dansanti proposes in #4561 (comment)

Hello @hbrunn ,

Thank you for your suggestion. It is preferable to make a different PR for each module. The website_sale_digital script will be done later. Although it's always welcome if you prefer to do it yourself to get ahead of the work.

Regards

@dansanti
Copy link

hi! @pilarvargas-tecnativa website_sale_digital was merged with website_sale please add this scripts:

openupgrade.logged_query(
    env.cr,
    """
    UPDATE product_document
    SET attached_on = 'sale_order'
    FROM ir_attachment ir
    WHERE product_document.ir_attachment_id = ir.id
      AND ir.product_downloadable = TRUE
    """
)```

@pilarvargas-tecnativa
Copy link
Contributor Author

hi! @pilarvargas-tecnativa website_sale_digital was merged with website_sale please add this scripts:

Hi @dansanti thanks for your work. I had already commented it with @hbrunn before but I reiterate my words, it's better to make a separate PR for each module. I take into account your suggestions to do it later but it's always welcome if someone wants to do that PR.

My regards

Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-4687-by-MiquelRForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 17, 2025
Signed-off-by MiquelRForgeFlow
@OCA-git-bot
Copy link
Contributor

@MiquelRForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-4687-by-MiquelRForgeFlow-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@MiquelRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-4687-by-MiquelRForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 17, 2025
Signed-off-by MiquelRForgeFlow
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 741f443. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow
Copy link
Contributor

@pilarvargas-tecnativa please do website_sale_digital :)

@pedrobaeza pedrobaeza deleted the 17.0-mig-website_sale branch March 17, 2025 15:32
@pedrobaeza
Copy link
Member

We don't need that module for now.

@MiquelRForgeFlow
Copy link
Contributor

website_sale_digital handled in #4879.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants