[17.0][OU-ADD] hr_recruitment: Migration to 17.0 #4703
Conversation
|
/ocabot migration hr_recruitment |
openupgrade_scripts/scripts/hr_recruitment/17.0.1.1/upgrade_analysis_work.txt
Outdated
Show resolved
Hide resolved
| hr_recruitment / hr.applicant / email_normalized (char) : NEW isfunction: function, stored | ||
| hr_recruitment / hr.applicant / message_bounce (integer) : NEW hasdefault: default | ||
| hr_recruitment / hr.applicant / partner_mobile_sanitized (char): NEW isfunction: function, stored | ||
| hr_recruitment / hr.applicant / partner_phone_sanitized (char): NEW isfunction: function, stored | ||
| hr_recruitment / hr.applicant / phone_mobile_search (char) : NEW | ||
| hr_recruitment / hr.applicant / phone_sanitized (char) : NEW isfunction: function, stored |
There was a problem hiding this comment.
too many functions. shouldn't we try to fill this new columns by query? 🤔
There was a problem hiding this comment.
I looked into these ones and they are calling mixin python functions to sanitize / format email and phone wihch for phone depends on localization for instance, so I think it makes more sense to let Odoo compute these fields with Python functions rather than trying to do the same in SQL to reduce migration time !
remi-filament
force-pushed
the
17.0-hr_recruitment
branch
from
d08fc8e to
cc8ac66
Compare
|
Thanks for your review @MiquelRForgeFlow I implemented 2 out of your 3 comments and replied on the last one. |
remi-filament
force-pushed
the
17.0-hr_recruitment
branch
from
cc8ac66 to
135cdd6
Compare
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 1078b6c. Thanks a lot for contributing to OCA. ❤️ |
4 participants
No description provided.