Skip to content

Conversation

@carlos-lopez-tecnativa
Copy link
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa commented Feb 27, 2025

Supersedes #4671
TT49916
@Tecnativa @pedrobaeza @MiquelRForgeFlow could you please review this?

@MiquelRForgeFlow
Copy link
Contributor

Could you maintain the commit in #4671 and then add you a second commit with your improvements?

@carlos-lopez-tecnativa
Copy link
Contributor Author

Could you maintain the commit in #4671 and then add you a second commit with your improvements?

Could you specify the relevant changes in this PR? I started from scratch because, from my point of view, these changes are incorrect. The author is dropping a SQL unique constraint on unique_contact_list, but this constraint is still present. So, if I preserve this change, I would need to revert it again in my commit. Additionally, most of the changes in the upgrade_analysis_work.txt file are marked as "NOTHING TO DO," whereas, in reality, there is still a lot of work to be done.

@MiquelRForgeFlow
Copy link
Contributor

Ok, I was asking for to make it easier the review process. With your way, I will need to compare the two PRs 🤷‍♂️

@carlos-lopez-tecnativa
Copy link
Contributor Author

Ok, I was asking for to make it easier the review process. With your way, I will need to compare the two PRs 🤷‍♂️

Ok, sorry. I need to add "superseded" because the intention is to close the other PR without merging.

@MiquelRForgeFlow
Copy link
Contributor

/ocabot migration mass_mailing

@MiquelRForgeFlow
Copy link
Contributor

MiquelRForgeFlow commented Mar 3, 2025

please rebase (and handle above comment)

# NOTHING TO DO: new feature

mass_mailing / utm.campaign / ab_testing_completed (boolean): now a function
# NOTHING TO DO: now is compute with store=True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialize the column in pre and do a SQL for assigning the value on post after processing ab_testing_winner_mailing_id. If not, the ORM computation will take place before and this won't have a valid value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field already exist in V16 https://github.com/odoo/odoo/blob/34947c01623a9fc753197bd55d6121d9c6fa682f/addons/mass_mailing/models/utm_campaign.py#L25, so recomputation is not triggered. Why is it necessary to initialize the column? Please clarify.

@pedrobaeza pedrobaeza merged commit 9861239 into OCA:17.0 Mar 12, 2025
4 checks passed
@pedrobaeza pedrobaeza deleted the 17.0-mig-mass_mailing branch March 12, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants