Skip to content

[17.0][OU-FIX] hr_recruitment: Ensure order is preserved #4811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedrobaeza merged 1 commit into from
Mar 11, 2025
Merged

[17.0][OU-FIX] hr_recruitment: Ensure order is preserved #4811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions openupgrade_scripts/scripts/hr_recruitment/17.0.1.1/pre-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,15 @@
# Copyright 2025 Le Filament (https://le-filament.com)
# Copyright 2025 Tecnativa - Pedro M. Baeza
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
from openupgradelib import openupgrade


def _fill_sequence_hr_applicant_refuse_reason(cr):
openupgrade.logged_query(
cr,
"""
ALTER TABLE hr_applicant_refuse_reason
ADD COLUMN IF NOT EXISTS sequence INTEGER DEFAULT 10;
""",
)
openupgrade.logged_query(
cr,
"""
ALTER TABLE hr_applicant_refuse_reason ALTER COLUMN sequence DROP DEFAULT;
""",
"ALTER TABLE hr_applicant_refuse_reason ADD COLUMN IF NOT EXISTS sequence int4",
)
openupgrade.logged_query(cr, "UPDATE hr_applicant_refuse_reason SET sequence=id")


@openupgrade.migrate(use_env=False)
Expand Down
4 changes: 1 addition & 3 deletions openupgrade_scripts/scripts/hr_recruitment/17.0.1.1/upgrade_analysis_work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,8 @@ hr_recruitment / hr.applicant / rating_ids (one2many) : NEW
# NOTHING TO DO: new fields

hr_recruitment / hr.applicant.refuse.reason / _order : _order is now 'sequence' ('id')
# NOTHING TO DO: new field sequence used to order

hr_recruitment / hr.applicant.refuse.reason / sequence (integer) : NEW hasdefault: default
# DONE: pre-migration: pre-create column with default value
# DONE: pre-migration: pre-create column and assign id as sequence for preserving previous order

hr_recruitment / hr.job / applicant_properties_definition (properties_definition): NEW
# NOTHING TO DO: new properties field
Expand Down
Loading