[17.0][OU-IMP] delivery: Finish migration scripts #4885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| JOIN product_product p ON sol.product_id = p.id | ||
| JOIN product_template pt ON p.product_tmpl_id = pt.id | ||
| WHERE pt.type IN ('product', 'consu') | ||
| AND (sol.is_delivery IS NULL OR sol.is_delivery = FALSE) |
Contributor
There was a problem hiding this comment.
Suggested change
| AND (sol.is_delivery IS NULL OR sol.is_delivery = FALSE) | |
| AND NOT sol.is_delivery |
Contributor
Author
There was a problem hiding this comment.
This is not working correctly.
With your proposal, the result is:
With the current code, the result is:
Because you have true, false, null:
Contributor
There was a problem hiding this comment.
Oh sorry.
FYI Equivalent options:
Suggested change
| AND (sol.is_delivery IS NULL OR sol.is_delivery = FALSE) | |
| AND NOT COALESCE(sol.is_delivery, FALSE) |
Suggested change
| AND (sol.is_delivery IS NULL OR sol.is_delivery = FALSE) | |
| AND sol.is_delivery IS DIFFERENT FROM TRUE |
Suggested change
| AND (sol.is_delivery IS NULL OR sol.is_delivery = FALSE) | |
| AND (sol.is_delivery IS NULL OR sol.is_delivery = FALSE) |
carlos-lopez-tecnativa
force-pushed
the
17.0-mig-delivery
branch
from
d4b9208 to
62995ab
Compare
MiquelRForgeFlow
approved these changes
Mar 27, 2025
Contributor
|
/ocabot merge nobump |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 343966c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4751
TT52315
@Tecnativa @pedrobaeza @MiquelRForgeFlow could you please review this?