Skip to content

Conversation

@BhaveshHeliconia
Copy link
Contributor

No description provided.

@legalsylvain
Copy link
Contributor

legalsylvain commented May 9, 2025

/ocabot migration sale

Depends on :

Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still evaluating if we need to do something with product combos.

Further, you need to load the noupdate changes and delete translations.

And don't forget to describe what you did in the work file

Comment on lines +6 to +7
Remove the outdated kanban view entry for 'action_quotations' (Odoo 17)
to prevent duplicate key constraint violation during migration to Odoo 18.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't remove it. the problem is caused by the view entry with this xmlid being attached to action_quotations in v17 and to action_quotations_with_onboarding in v18.

So I think the correct solution is to rename the xmlid sale.sale_order_action_view_quotation_kanban to sale.action_quotations_kanban

Comment on lines +6 to +7
sale / product.document / attached_on (selection) : DEL selection_keys: ['quotation', 'sale_order']
sale / product.document / attached_on_sale (selection) : NEW required, selection_keys: ['hidden', 'quotation', 'sale_order'], hasdefault: default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to set attached_on_sale from attached_on

---Fields in module 'sale'---
sale / account.analytic.applicability / business_domain (False) : selection_keys is now '['bill', 'expense', 'general', 'invoice', 'manufacturing_order', 'purchase_order', 'sale_order', 'stock_picking', 'timesheet']' ('['bill', 'expense', 'general', 'invoice', 'manufacturing_order', 'purchase_order', 'sale_order']')
sale / account.move.line / is_downpayment (boolean) : module is now 'purchase' ('sale')
sale / product.category / property_account_downpayment_categ_id (many2one): NEW relation: account.account
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set this per company from the account of sale_down_payment_product_id below with the standard fallbacks to category of company's income account

sale / sale.order.line / linked_virtual_id (char) : NEW
sale / sale.order.line / qty_invoiced_posted (float) : previously in module l10n_it_edi_doi
sale / sale.order.line / selected_combo_items (char) : NEW
sale / sale.order.line / technical_price_unit (float) : NEW
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this column should be precreated and filled with the value of price_unit (cf https://github.com/odoo/odoo/blob/18.0/addons/sale/models/sale_order_line.py#L574)

@OCA-git-bot OCA-git-bot mentioned this pull request May 27, 2025
@MiquelRForgeFlow
Copy link
Contributor

Supeseded by #5071.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants