[18.0][OU-ADD] hr_expense: Nothing to do #5016
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_expense
branch
from
721a2de to
45a7f8a
Compare
Contributor
|
/ocabot migration hr_expense |
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_expense
branch
from
45a7f8a to
08f045f
Compare
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_expense
branch
from
08f045f to
dfb1159
Compare
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_expense
branch
from
dfb1159 to
880fee6
Compare
remi-filament
suggested changes
Jun 10, 2025
Contributor
There was a problem hiding this comment.
Hi @BhaveshHeliconia thanks for this PR.
I am afraid there are things to do on that one, at least :
- making sure payment_mode is filled on hr.expense
- manually remove hr_expense.ir_rule_hr_expense_employee_not_draft
- load noupdate_changes.xml
Member
|
Superseded by #5130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.