[18.0][IMP] Update analysis files

[github-actions]

Analysis or noupdate changes for modules marked as done:

• account
• account_edi_ubl_cii
• base
• event
• event_sale
• hr
• l10n_fr
• l10n_fr_account
• l10n_my_edi_extended
• l10n_sa
• mail
• mrp_account
• payment
• product
• sale
• web_hierarchy

[hbrunn]

this script needs to be changed to operate on a copy of the noupdate_changes.xml file

[pedrobaeza]

That technique will require the same some human intervention. Maybe we can use this technnique:

• Have the previous noupdate_changes.xml (we can freeze a copy like we do with update_analysis.txt). Maybe this can be manually done when requiring to modify the file.
• Get the new noupdate_changes.xml.
• Get the diff between both (if any).
• Apply the diff to the modified file.

[hbrunn]

it doesn't require human intervention for cases like the current one where the changes file isn't changed, only when there are actually changes, which are rare.

the diff method can fail so many ways as soon as there are non-trivial changes made that I didn't consider this worth the effort for cases where it works when writing the script.

I don't see a problem in copying noupdate_changes.xml to noupdate_changes_work.xml, and modifying + loading that. A useful extension of the bot script would be to flag modules where this has happened and the noupdate_changes.xml file is changed.

A more radical but possibly more useful approach could be to allow to pass modifications directly to load_data in view inheritance style (because barely anyone speaks xslt). In this case, this would be

openupgrade.load_data(
    env, "payment_custom", "18.0.2.0/noupdate_changes.xml",
    modifications="""
    <xpath expr="//record[@id='payment_method_wire_transfer']/field[@name='active']" position="replace" />
    """,
)

curious what @OCA/openupgrade-maintainers think

[pedrobaeza]

OK, let's go with that procedure:

• Don't touch in this script anything.
• When having to modify noupdate_changes.xml for something, we copy it to noupdate_changes_work.xml and load this second one.
• If any diff detected in these PRs, we adjust it in the work file if needed.

[pedrobaeza]

Implemented in #5145

[pedrobaeza]

Should we wait for OCA/server-tools#3325 ?

[MiquelRForgeFlow]

I think there is no need to force push this PR, as the bot would have done this next week anyways.

[pedrobaeza]

So do you mean to close it, let it open, merge it and wait for the next one...?

[MiquelRForgeFlow]

If you haven't done the force push, I would have said to let it open and wait next week for the PR being automatically updated.
Now, although you have already done the force push, there is still OCA/server-tools#3325, so we can wait until that PR is merged/closed and this one is automatically updated anyway 🤷‍♂️

[pedrobaeza]

Clarification: I have just rebased the branch with the GitHub interface option.