-
-
Notifications
You must be signed in to change notification settings - Fork 785
[18.0][IMP] Update analysis files #5157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All the changes are elements reordering. Is this going to happen continuously? |
openupgrade_scripts/scripts/account_peppol/18.0.1.1/upgrade_analysis.txt
Outdated
Show resolved
Hide resolved
4ffea93 to
431ea0b
Compare
| account / account.move / audit_trail_message_ids (one2many): NEW relation: mail.message | ||
| account / account.move / checked (boolean) : NEW | ||
| account / account.move / invoice_currency_rate (float) : NEW isfunction: function, stored | ||
| account / account.move / invoice_currency_rate (float) : NEW hasdefault: compute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in odoo/odoo@2d486fb. Anyway, previously, if not renamed, it was needed to be pre-added and computed via SQL. Can you check, @MiquelRForgeFlow ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that commit, invoice_currency_rate was made editable, but is hasn't changed in the way it is computed.
But, regarding to pre-creating it, I think I avoided to do it due the difficulty to convert the compute into SQL.
Feel free to improve the code :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MiquelRForgeFlow that's something you can't avoid, because if not, migrating from 17 to 18 with thousand of moves will trigger the computation and takes hours. Please complete the account migration with such thing, as it can be considered essential.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I don't have a clear way to do it right now. The needed query isn't simple.
Analysis or noupdate changes for modules marked as done: