[18.0][FIX] openupgrade_framework: fix return value for update_list method patch #5167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @legalsylvain, @StefanRijnhart, @hbrunn, |
pedrobaeza
changed the title
Member
|
If the returned result is handled, I think you should add the auto installed modules to the added returned value, isn't it? |
hbrunn
approved these changes
Jul 11, 2025
Member
hbrunn
left a comment
hbrunn
left a comment
There was a problem hiding this comment.
shouldn't we merge this first and talk about the details later?
Member
|
OK. I think it's everything related, but let's merge this for now. /ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 6e2ccf9. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since
update_listwill be called by other module, it will be better to keep the original return value