-
-
Notifications
You must be signed in to change notification settings - Fork 784
[19.0] initialize+openupgrade_framework #5395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19.0] initialize+openupgrade_framework #5395
Conversation
- Apply new copier template. (from v1.14.2 to v1.18 : replace setup by pyproject.toml, replace black by ruff, ...) - Disable .github/workflows/test.yml because the openupgrade is not initialized yet - add new empty modules160-170.rst file
…de is not initialized yet
.github/workflows/test.yml
-This commit remove unecessary patch -Check if test exist then execute it in the test.yml -Remove the test loader from patch, detail at OCA#4327 (comment)
account_peppol by now
|
/ocabot migration openupgrade_framework |
|
There's no issue in this repo with the title 'Migration to version 19.0' and the milestone 19.0, so not possible to add the comment. |
|
/ocabot migration openupgrade_framework |
e6a1234 to
21d73b8
Compare
…path does not exist
StefanRijnhart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but tests fail because of the logged warning and because of the missing 18.0 database in https://github.com/OCA/OpenUpgrade/releases
|
Oh, I see there is #5375. |
|
@StefanRijnhart added a commit that squelches the warning, and given #5375 was merged we have nearly working CI now |
StefanRijnhart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
i've already cherry picked them back then, so no, i think this is nearly good to go, i'd like to have the openupgrade test skip itself when no modules are marked as migrated though |
4f29cf2 to
9f45f79
Compare
StefanRijnhart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright!
My goal here is to reduce the amount of manual work when dealing with OpenUpgrade.
I proposed a somewhat modified script for branch initialization and following steps, which I used for creating this one.
Note that I renamed the migration test script to test-migration.yml, and keep the standard OCA test script for running unit tests. This should make it easier in future versions to determine which patches we still need, and if they're still effective.
You can see the full thing working on hbrunn#18, but I'm not done yet with the base migration, so no PR for this yet.
Meanwhile for making the migration test work as soon as the base module is migrated, please review #5389 and #5375