Skip to content

Conversation

@hbrunn
Copy link
Member

@hbrunn hbrunn commented Oct 3, 2025

My goal here is to reduce the amount of manual work when dealing with OpenUpgrade.

I proposed a somewhat modified script for branch initialization and following steps, which I used for creating this one.

Note that I renamed the migration test script to test-migration.yml, and keep the standard OCA test script for running unit tests. This should make it easier in future versions to determine which patches we still need, and if they're still effective.

You can see the full thing working on hbrunn#18, but I'm not done yet with the base migration, so no PR for this yet.

Meanwhile for making the migration test work as soon as the base module is migrated, please review #5389 and #5375

legalsylvain and others added 30 commits October 3, 2025 07:23
- Apply new copier template. (from v1.14.2 to v1.18 : replace setup by pyproject.toml, replace black by ruff, ...)
- Disable .github/workflows/test.yml because the openupgrade is not initialized yet
- add new empty modules160-170.rst file
-This commit remove unecessary patch
-Check if test exist then execute it in the test.yml
-Remove the test loader from patch, detail at
OCA#4327 (comment)
@hbrunn
Copy link
Member Author

hbrunn commented Oct 3, 2025

/ocabot migration openupgrade_framework

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Oct 3, 2025
@OCA-git-bot
Copy link
Contributor

There's no issue in this repo with the title 'Migration to version 19.0' and the milestone 19.0, so not possible to add the comment.

@hbrunn
Copy link
Member Author

hbrunn commented Oct 3, 2025

/ocabot migration openupgrade_framework

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 3, 2025
11 tasks
@MiquelRForgeFlow MiquelRForgeFlow self-requested a review October 8, 2025 12:28
kevin3274 added a commit to kh2u/OpenUpgrade that referenced this pull request Dec 1, 2025
@hbrunn hbrunn mentioned this pull request Dec 5, 2025
3 tasks
@hbrunn hbrunn mentioned this pull request Dec 12, 2025
3 tasks
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but tests fail because of the logged warning and because of the missing 18.0 database in https://github.com/OCA/OpenUpgrade/releases

@StefanRijnhart
Copy link
Member

Oh, I see there is #5375.

@hbrunn
Copy link
Member Author

hbrunn commented Dec 24, 2025

@StefanRijnhart added a commit that squelches the warning, and given #5375 was merged we have nearly working CI now

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do we need a 'rebase' to include #5445 and #5448?

@hbrunn
Copy link
Member Author

hbrunn commented Dec 24, 2025

i've already cherry picked them back then, so no, i think this is nearly good to go, i'd like to have the openupgrade test skip itself when no modules are marked as migrated though

@hbrunn hbrunn force-pushed the 19.0-initialize+openupgrade_framework branch from 4f29cf2 to 9f45f79 Compare December 25, 2025 07:42
@hbrunn
Copy link
Member Author

hbrunn commented Dec 25, 2025

now there's a commit that skips subsequent steps in the test-migration workflow if there are no modules to test. I rebased #5446 on this to prove that when there are modules to test, these steps run indeed.

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright!

@pedrobaeza pedrobaeza merged commit a4c37b3 into OCA:19.0 Dec 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.