[18.0][OU-FIX] hr_holidays: remove if employee is inactive #5398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiquelRForgeFlow
force-pushed
the
fix-holidays-better
branch
from
b14fec1 to
bf6e7e0
Compare
Contributor
Author
|
@remi-filament what do you think? |
remi-filament
suggested changes
Oct 8, 2025
Contributor
remi-filament
left a comment
remi-filament
left a comment
There was a problem hiding this comment.
I think it will take more time to do a browse then filtered (that will need to fetch fields from hr_employee) rather that doing it in SQL, but it should work the same !
Contributor
Author
Yes, but I am afraid that if in some case all employees are inactive in a leave, then the leave will not be selected, right? |
remi-filament
approved these changes
Oct 8, 2025
pedrobaeza
added a commit
that referenced
this pull request
Dec 17, 2025
As first, employee_ids are being filtered by active, but the if was not changed in #5398 ``` File ".../openupgrade_scripts/scripts/hr_holidays/18.0.1.6/pre-migration.py", line 206, in migrate split_employee_leaves(env) File ".../openupgrade_scripts/scripts/hr_holidays/18.0.1.6/pre-migration.py", line 162, in split_employee_leaves SET employee_id = {employees[0].id} File "/opt/odoo/custom/src/odoo/odoo/models.py", line 7082, in __getitem__ return self.browse((self._ids[key],)) IndexError: tuple index out of range ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #5396.