[18.0][FIX] account_financial_report: journal ledger move_line_ids_taxes_data

[qgroulard]

In the journal ledger report, only move lines with tax_line_id had their taxes displayed.
The case where taxes come from move_line_ids_taxes_data seems to have been forgotten.

We solve two problems.
First, move_line_ids_taxes_data was never propagated, thus always empty.
Second, tax name and description get from sql queries are json values. We now handle translations.

[flotho]

ping @DorianMAG

[flotho]

Hi,

Thanks for this usefull PR.
Code could be optimized.
You defined L206 the lang variable. Its value is either en_US or another one, never None AFAICS.
Though, you don't need anymore to switch case on lang in L221 and L223
Could you change this ?

Regards

[qgroulard]

Hi,

Thanks for this usefull PR. Code could be optimized. You defined L206 the lang variable. Its value is either en_US or another one, never None AFAICS. Though, you don't need anymore to switch case on lang in L221 and L223 Could you change this ?

Regards

Hi, thanks for your review.

The thing is you don't necessarily have a translation for your current language.
If you look in DB, even though a language is installed, translatable fields will have no other key than "en_US" until they are actually translated once.

[flotho]

Hi,
Thanks for this usefull PR. Code could be optimized. You defined L206 the lang variable. Its value is either en_US or another one, never None AFAICS. Though, you don't need anymore to switch case on lang in L221 and L223 Could you change this ?
Regards

Hi, thanks for your review.

The thing is you don't necessarily have a translation for your current language. If you look in DB, even though a language is installed, translatable fields will have no other key than "en_US" until they are actually translated once.

Thanks for the answer.
I thought I've understood what you want to do.
What I'm proposing is to change this :
"name": tax_name.get(lang) or tax_name.get("en_US"),
By
"name": tax_name.get(lang),
You can do this because you defined a lang variable with a default value that will be en_US. So the test you made is redundant regarding the possible values in the lang variable.
Am I missing something?
regards

[qgroulard]

Let's say I have French and English installed on my DB and my current language is French.

• lang = "fr_FR"
• tax_name might be: {"en_US": "Tax 21%"}

Hence, tax_name.get(lang) will return False, which will eventually end up as an empty column in the report.

What I have implemented is a fallback on English translation. This is similar to what the ORM does, if you open the form view of the tax the name won't be empty if you have no French translation, the English name will be displayed instead.

[flotho]

Thanks for your clear answer.

I missed this one that data in the json could be "de"synchronized from installed languages.

So evrything is OK
LGTM