[16.0][FIX] account_financial_report: Don't crash trial balance with partner details #1420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
requested review from
alexis-via,
carlos-lopez-tecnativa and
victoralmau
…r details
When using the trial balance clicking on "Show partner details", you get
the following crash:
```
File ".../account_financial_report/models/ir_actions_report.py", line 19, in _render_qweb_html
return super(IrActionsReport, obj)._render_qweb_html(
File ".../odoo/addons/base/models/ir_actions_report.py", line 984, in _render_qweb_html
data = self._get_rendering_context(report, docids, data)
File ".../odoo/addons/base/models/ir_actions_report.py", line 999, in _get_rendering_context
data.update(report_model._get_report_values(docids, data=data))
File ".../account_financial_report/report/trial_balance.py", line 884, in _get_report_values
total_amount, accounts_data, partners_data = self._get_data(
File ".../account_financial_report/report/trial_balance.py", line 550, in _get_data
total_amount, partners_data = self._compute_partner_amount(
File ".../account_financial_report/report/trial_balance.py", line 368, in _compute_partner_amount
tmp_list = sorted(
TypeError: '<' not supported between instances of 'int' and 'str'
```
That's because the dictionary containing data (total_amount) contains
subdictionaries by account id, that mix both subdetails by partner with
direct totalized data.
On the sorted call, there's a condition for using other sorting key
trying to prevent this problem, but it was not enough, as the fallback
key is an integer (account id), not a string like the others.
Thus, let's bring a string sorting key for not having this crash. The
key thas has been selected is "!", being the first printable ASCII char.
On the same mood, those details without partner, have as partner name
"Missing partner" (or its translation), so they are sorted in the middle
of the list due to this. Using for these cases "\xff" as sorting key,
being the last printable Unicode char, ensures they are put at the end
of the list of each account.
TT59770
pedrobaeza
force-pushed
the
16.0-fix-account_financial_report-partner_order
branch
from
b9d3c4b to
36d46aa
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup of #1240
When using the trial balance clicking on "Show partner details", you get the following crash:
That's because the dictionary containing data (total_amount) contains subdictionaries by account id, that mix both subdetails by partner with direct totalized data.
On the sorted call, there's a condition for using other sorting key trying to prevent this problem, but it was not enough, as the fallback key is an integer (account id), not a string like the others.
Thus, let's bring a string sorting key for not having this crash. The key thas has been selected is "!", being the first printable ASCII char.
On the same mood, those details without partner, have as partner name "Missing partner" (or its translation), so they are sorted in the middle of the list due to this. Using for these cases "\xff" as sorting key, being the last printable Unicode char, ensures they are put at the end of the list of each account.
@Tecnativa TT59770