Skip to content

[FIX] account_check_deposit - fix stacktrace when no account_journal_payment_debit_account found #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baimont wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[FIX] account_check_deposit - fix stacktrace when no account_journal_payment_debit_account found #2163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions account_check_deposit/models/account_check_deposit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,22 +242,22 @@ def _prepare_move_vals(self):
total_debit = self.company_id.currency_id.round(total_debit)
total_amount_currency = self.currency_id.round(total_amount_currency)

counterpart_account_id = False
counterpart_account = False
for line in self.bank_journal_id.inbound_payment_method_line_ids:
if line.payment_method_id.code == "manual" and line.payment_account_id:
counterpart_account_id = line.payment_account_id.id
counterpart_account = line.payment_account_id
break
# inspired by _get_outstanding_account() on account.payment
if not counterpart_account_id:
if not counterpart_account:
chart_template = self.with_context(
allowed_company_ids=self.company_id.root_id.ids
).env["account.chart.template"]
counterpart_account_id = chart_template.ref(
counterpart_account = chart_template.ref(
"account_journal_payment_debit_account_id", raise_if_not_found=False
).id
if not counterpart_account_id:
counterpart_account_id = self.company_id.transfer_account_id.id
if not counterpart_account_id:
)
if not counterpart_account:
counterpart_account = self.company_id.transfer_account_id
if not counterpart_account:
raise UserError(
_("Missing 'Internal Transfer' account on the company '%s'.")
% self.company_id.display_name
Expand All @@ -284,7 +284,7 @@ def _prepare_move_vals(self):
0,
0,
{
"account_id": counterpart_account_id,
"account_id": counterpart_account.id,
"partner_id": False,
"debit": total_debit,
"currency_id": self.currency_id.id,
Expand Down