[19.0] [MIG] account_chart_update: Migration to 19.0 #2169

arantxa-s73 · 2025-11-10T12:49:28Z

Module migrated to version 19.0

[FIX]: Changed types to orm.Model, orm.TransientModel and orm.AbstractModel. [FIX]: Fix deletion method for some fields of objects. [FIX]: Contributions have been written in the standard format of the community. [FIX]: Changes in the form to work as a real wizard. [FIX]: Remove 'init_xml' keys, because it's no longer needed in v7. [FIX]: Rename 'demo_xml' key to the new standard 'demo'. [FIX]: Change imports calls. [FIX]: Remove __author__ variables in files, because authors are put on manifest file (__openerp__.py). [FIX]: Update view definitions to version 7.0 [FIX]: Rename variables to OpenERP standard. [FIX]: Increased compatibility with standard PEP8. [IMP]: User Invitu add the method call _reopen to keep open the wizard. [MRG]: User Invitu add frech language.

…permission.

…ntation

…ing. [FIX] account_chart_update: Adapted to work with inherited account chart templates. [FIX] account_chart_update: Remove required=True for chart_template_id on DB and put on screen to avoid error when removing chart templates. [FIX] account_chart_update: Change method to compare taxes of fiscal positions to match with the one comparing taxes. [FIX] account_chart_update: Change method to compare accounts of fiscal positions to match with the one comparing accounts. [IMP] account_chart_update: Wizard now shows in tree view modification notes. [IMP] account_chart_update: For new data to be created, it is marked on notes the reason for the creation (just for clarity). [IMP] account_chart_update: Tabs for operations that are not going to be performed are hidden. [IMP] account_chart_update: Some PEP8 here and there. [IMP] account_chart_update: Enhance a little the mapping searches (there's more room to improve). [IMP] account_chart_update: Now it takes into account name and description for mapping taxes.

* Move out of unported * Set account_chart_update installable * value_reference of ir.property is a char * Use get_by_record method of ir.property * number digits is returned before assignment in case of property exist but account not * product_obj isn't used

* search on code first to match tax codes The tax code code should be more discriminant that the tax code name. * compare more fields in tax codes * deletion of tax codes removed from templates For tax codes, it make sense to propose deletion, since tax codes are normally defined by the tax authority and the user does not customize them. * update accounts on taxes even if an update of the account was not requested Useful when the chart of taxes changes but the chart of account need not be updated. * depth-first search of tax codes This helps creating parents before children. * compare more fields in taxes * add active field on tax code Deactivate tax codes which are not in the template. * deactivate taxes that are not in the template * multi-company criteria for taxes * avoid inserting duplicates in presence of inactive taxes or tax codes

* Fix calculated field when showing inactives + add field to view * Migrated to new API. * Provided hooks for detecting changes and for adding update/create values. * Purge dead error detection code (not applying). * Use global mapping dictionaries stored on class instead of passing arguments down to top and viceversa. * Number fields computed by a function field instead of being computed by hand. * Use recordsets as indexes instead of ids to avoid repetitive browses. * Re-enable local cache variables * README + authors

* Set updated taxes as active * Check parent_id field in '_is_different_tax' method * PEP8 * Spanish translation

…cache. Closes OCA#240

As there's a constraint that forbids to write the code of the account if it has moves, we delete the corresponding entry on update only, because the method that prepares the values is the same for new and existing accounts.

* Process price_include field * Detect change in price_include field

- New-style license headers. - Remove .pot file. - Remove tax codes stuff, now removed from v9. - Refactor methods for search, create, update, delete. Now they are smaller, fitter, happier, more productive. - Only update fields that have any kind of change on any updated record. - Place the wizard in the configuration page, instead of its own menu item. - Display amount of disabled taxes at ending page.

…tions + clean authors As this module has been written from scratch with a totally different technique, I clean the list and update copyrights.

…me (OCA#651)

When marking methods as ormcache, you can't return recordsets, as they keep the cursor information, and that cursor can be closed (worker spawn for example) when you need to access again data. This is fixed returning IDs instead, and browsing when needed

* Compare all fields from template Not all fields were properly compared with previous code. This means also to exclude some of them, but now we have a full and extensible system. * Optimize cached method * Generate accounts and fiscal positions using Odoo methods (tax already did) * README by fragments * Add tests up to full coverage

In v10, tax templates have an active flag. It is useful to copy them too, letting the user select which one he wants to activate in it's instance.

With this option, you can select which fields do you want to compare for updating. Use case: you have specific accounts in taxes, and you don't want to lose them, but you want to update their groups through the wizard. Before this, the update was all or nothing. Now, you have total control! Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Currently translated at 100.0% (100 of 100 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_chart_update/de/

MT-7597

… and ditch decorators as mentioned in code review [BOT] post-merge updates

Changes done: - Purge translations - Squash administrative commits - Change name_get to _compute_display_name - Change attrs to invisible/required - Adapt to the new account.chart.template system without records - Remove recreate_xml_ids fields (It is always necessary for them to have the expected xml_id) TT49275

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_chart_update/

Currently translated at 100.0% (104 of 104 strings) Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_chart_update/it/

Related to OCA#2123 (comment) It is very important that the order is correct, i.e., you must try to create (for example) the accounts first, which will then be linked to the tax that will be created, or that error will occur. Similarly, it is also necessary to take tax groups into account and process them before taxes to prevent taxes from being created/updated for the wrong group.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-18.0/account-financial-tools-18.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-18-0/account-financial-tools-18-0-account_chart_update/

Currently translated at 100.0% (118 of 118 strings) Translation: account-financial-tools-18.0/account-financial-tools-18.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-18-0/account-financial-tools-18-0-account_chart_update/it/

Reyes4711-S73

LGTM

Reyes4711-S73 · 2025-11-12T08:03:33Z

@OCA/accounting-maintainers Please, can you merge this PR?

OCA-git-bot · 2025-11-15T13:00:04Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2025-11-17T20:35:56Z

account_chart_update/tests/test_account_chart_update.py

        self.assertEqual(wizard.state, "ready")
        self.assertFalse(wizard.tax_group_ids)
-        self.assertFalse(wizard.tax_ids)
+        self.assertTrue(wizard.tax_ids)


These changes on the tests highlights that something is not going correct, so please review why they are happening.

There are already rates on the template; I cannot indicate that there are none if they are included.

But there shouldn't be changes on the first run, as the chart template should be dumped as is. And the same for the rest of the modified test.

In the function, _find_taxes, at the end of the entire function, regardless of whether they are created, added, or deleted, it always fills in the tax_ids field.

AFAIK, it returns something if there are changes, which they shouldn't:

https://github.com/OCA/account-financial-tools/pull/2169/files#diff-72a37f755deba0ba1be71eb2e6d1eb440f66d19bc018731c66516fcb542de5afR811

In the first tax search, the taxes already exist, but since the diff_notes method finds something different, it adds them to tax_vals, and if tax_vals has values, it is added to self.tax_ids.

Yes, and that shouldn't happen, as there shouldn't be any difference, so something is not correct.

The template it uses as a basis has changed versions. In the previous version, it did not have a tax position, but in version 19.0 it does. When I update from the wizard, it marks them for me. In this case, how would I proceed?

percevaq and others added 30 commits November 10, 2025 12:38

[IMP] account_chart_update: Menu path to avoid needing multi-company …

e288c00

…permission.

[IMP] small improvement : calling reopen method in action_init + inde…

b9a55cd

…ntation

FIX: wrong dict passed in _update_accounts

57277a9

[IMP] attempt to match tax code on code if no match on name was found

2b8b8d1

Set all addons to uninstallable

fc0a296

[FIX+IMP] account_chart_update: Several things

5b7fd01

* Set updated taxes as active * Check parent_id field in '_is_different_tax' method * PEP8 * Spanish translation

[FIX] account_chart_update: Call mapping function instead of removed …

bdcac26

…cache. Closes OCA#240

[FIX][account-financial-tools] depends key is duplicated

05f4f65

[FIX] account_chart_update: Don't write code on account update

d5e5ddd

As there's a constraint that forbids to write the code of the account if it has moves, we delete the corresponding entry on update only, because the method that prepares the values is the same for new and existing accounts.

[FIX] Include acc templates from parent CoA templates

ff26783

[FIX] account_chart_update:

9943397

* Process price_include field * Detect change in price_include field

[FIX+IMP] account_chart_update: Fix fiscal position mapping + transla…

5c3b922

…tions + clean authors As this module has been written from scratch with a totally different technique, I clean the list and update copyrights.

[MIG] account_chart_update: Migration to 10.0

a5cf9fc

[FIX] account_chart_update: Fetch account code digits correctly

ecfe895

[MIG][ADD] i18n directly from 10.0

f0d1ff7

[FIX] account_chart_update: Limit fiscal position search with same na…

e3cc0ba

…me (OCA#651)

account_chart_update: copy inactive tax templates too

ec5ccc1

In v10, tax templates have an active flag. It is useful to copy them too, letting the user select which one he wants to activate in it's instance.

[MIG] account_chart_update: Migration to 11.0

af91971

[MIG] account_chart_update: Additional needed changes

30c5dc5

[FIX] account_chart_update: Handle updated m2m correctly

1d3c811

Eduardo López Peñalver and others added 18 commits November 10, 2025 12:38

[16.0] account_chart_update - separate common data from actual tests

b847563

MT-7597

[16.0][ADD] account_chart_update_multilang

99b8c93

MT-7597

[FIX] account_chart_update_multilang: hide default language in wizard…

da294ca

… and ditch decorators as mentioned in code review [BOT] post-merge updates

[IMP] account_chart_update: pre-commit auto fixes

fd70a06

[MIG] account_chart_update: Migration to 17.0

4cf8c52

[MIG] account_chart_update: Migration to 18.0

bf5670b

[MIG] account_chart_update: Finish migration to 18.0

352a1b5

[UPD] Update account_chart_update.pot

6a9119a

[BOT] post-merge updates

d3b3f25

[UPD] Update account_chart_update.pot

ad4bdbf

[BOT] post-merge updates

499961d

[IMP] account_chart_update: pre-commit auto fixes

83ed135

arantxa-s73 force-pushed the 19.0-mig-account_chart_update branch from 028a39f to fe7a9e2 Compare November 11, 2025 08:22

[MIG] account_chart_update: Migration to 19.0

086b1a7

arantxa-s73 force-pushed the 19.0-mig-account_chart_update branch from fe7a9e2 to 086b1a7 Compare November 11, 2025 08:26

Reyes4711-S73 approved these changes Nov 12, 2025

View reviewed changes

Raul-S73 approved these changes Nov 12, 2025

View reviewed changes

OCA-git-bot added the approved label Nov 12, 2025

OCA-git-bot added the ready to merge label Nov 15, 2025

pedrobaeza requested changes Nov 17, 2025

View reviewed changes

OCA-git-bot removed approved ready to merge labels Nov 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[19.0] [MIG] account_chart_update: Migration to 19.0 #2169

[19.0] [MIG] account_chart_update: Migration to 19.0 #2169

Uh oh!

arantxa-s73 commented Nov 10, 2025

Uh oh!

Reyes4711-S73 left a comment

Uh oh!

Reyes4711-S73 commented Nov 12, 2025

Uh oh!

OCA-git-bot commented Nov 15, 2025

Uh oh!

pedrobaeza Nov 17, 2025

Uh oh!

arantxa-s73 Nov 18, 2025

Uh oh!

pedrobaeza Nov 18, 2025

Uh oh!

arantxa-s73 Nov 18, 2025

Uh oh!

pedrobaeza Nov 18, 2025

Uh oh!

arantxa-s73 Nov 19, 2025

Uh oh!

pedrobaeza Nov 19, 2025

Uh oh!

arantxa-s73 Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

[19.0] [MIG] account_chart_update: Migration to 19.0 #2169

Are you sure you want to change the base?

[19.0] [MIG] account_chart_update: Migration to 19.0 #2169

Uh oh!

Conversation

arantxa-s73 commented Nov 10, 2025

Uh oh!

Reyes4711-S73 left a comment

Choose a reason for hiding this comment

Uh oh!

Reyes4711-S73 commented Nov 12, 2025

Uh oh!

OCA-git-bot commented Nov 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants