[18.0][IMP] purchase_unreconciled: Mark write-off entries #2178
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronHForgeFlow
force-pushed
the
18.0-imp-purchase_unreconciled-mark-am
branch
from
2b2655d to
06bd3c6
Compare
JordiMForgeFlow
approved these changes
Dec 23, 2025
Contributor
JordiMForgeFlow
left a comment
JordiMForgeFlow
left a comment
There was a problem hiding this comment.
LGTM, not sure if the variable should be named differently though, like purchase_order_writeoff or purchase_order_reconcile, but the one you have chosen is also fine
AaronHForgeFlow
force-pushed
the
18.0-imp-purchase_unreconciled-mark-am
branch
from
06bd3c6 to
3bf5407
Compare
Contributor
Author
|
purchase_order_writeoff is fine to me :) |
JordiMForgeFlow
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for reporting purposes. Also took the chance to put a better name in the method