[18.0][IMP] account_move_line_purchase_info: Link Price difference entries #2180
+64
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JordiMForgeFlow
left a comment
JordiMForgeFlow
left a comment
There was a problem hiding this comment.
we could add a test to cover this new case
AaronHForgeFlow
force-pushed
the
18.0-imp-account_move_line_purchase_info-pdiff
branch
from
84b9150 to
8e5a0a1
Compare
Contributor
Author
|
Tests added 😇 BTW forward port is not needed after stock valuation apocalypse done in v19 |
| pdiff_amls = self.aml_model.search( | ||
| [ | ||
| ("move_id", "=", invoice.id), | ||
| ("account_id", "=", self.account_grni.id), |
Contributor
There was a problem hiding this comment.
shouldn't it be the price diff account?
Contributor
Author
There was a problem hiding this comment.
Yes, an actually, it is not working for some reason I need to investigate. Thanks.
…e difference journal items
AaronHForgeFlow
force-pushed
the
18.0-imp-account_move_line_purchase_info-pdiff
branch
from
8e5a0a1 to
8743f50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.