[16.0][ADD] account_move_group_restriction #2191
Open
+892
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanda999
reviewed
Dec 12, 2025
AungKoKoLin1997
force-pushed
the
16.0-add-account_move_group_restriction
branch
from
e452009 to
34496b9
Compare
yostashiro
reviewed
Dec 23, 2025
account_move_group_restriction/security/account_move_group_restriction_security.xml
Outdated
Show resolved
Hide resolved
account_move_group_restriction/security/account_move_group_restriction_security.xml
Outdated
Show resolved
Hide resolved
account_move_group_restriction/security/account_move_group_restriction_security.xml
Outdated
Show resolved
Hide resolved
AungKoKoLin1997
force-pushed
the
16.0-add-account_move_group_restriction
branch
from
67006b5 to
0741960
Compare
yostashiro
reviewed
Dec 23, 2025
| <field name="domain_force"> | ||
| ['|', | ||
| ('move_id.account_security_group_ids', '=', False), | ||
| ('move_id.account_security_group_ids', 'in', user.groups_id.ids) |
Member
There was a problem hiding this comment.
This allows users to access the move when they have ANY of the access groups involved (instead of all), which should not be something intended.
We may leave the design as is, since most use cases will involve only one such group, but we should add a ROADMAP.md to explain this limitation.
AungKoKoLin1997
force-pushed
the
16.0-add-account_move_group_restriction
branch
from
0741960 to
d98fba6
Compare
yostashiro
approved these changes
Dec 24, 2025
Member
yostashiro
left a comment
yostashiro
left a comment
There was a problem hiding this comment.
Code review. Just a couple of minor non-blocking points.
account_move_group_restriction/tests/test_account_move_group_restriction.py
Outdated
Show resolved
Hide resolved
AungKoKoLin1997
force-pushed
the
16.0-add-account_move_group_restriction
branch
from
d98fba6 to
b403a84
Compare
hoangtrann
approved these changes
Dec 30, 2025
Contributor
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module adds an "Allowed User Groups" field on accounts. By assigning this field, you can restrict which users are allowed to see journal items and journal entries that use those accounts.
@qrtl QT6166