Skip to content

Conversation

@u0f
Copy link

@u0f u0f commented Dec 11, 2025

This new module adds new logic for the number of digits in accounting accounts.

  • It is now possible to modify the number of digits throught the wizard. This is now saved for each company as the default value.
image
  • When the wizard is opened, instead of setting “6” as the default, the value saved for each company is used.

https://www.loom.com/share/5dbbb3b0d0774c1da417d49cf57fc833

MT-12933 @moduon

@u0f u0f force-pushed the add-account_chart_update_code_digits branch 2 times, most recently from 947e76e to 984a0e5 Compare December 11, 2025 14:52
@u0f u0f force-pushed the add-account_chart_update_code_digits branch 2 times, most recently from 902f926 to f2a3601 Compare December 16, 2025 10:18
@u0f u0f requested a review from EmilioPascual December 16, 2025 10:23
Copy link
Contributor

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm testing the module and I'm thinking the behavior is incomplete. The codes are not updated when you select new value in code digits. Maybe, you should see #2177

Please, add oca image to description.

@u0f u0f force-pushed the add-account_chart_update_code_digits branch from df1d7ce to cf4a275 Compare January 7, 2026 07:10
Copy link
Contributor

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @u0f

Copy link

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @u0f. Thank you for the effort but i think a review is required.
The following tests have been performed.

  • TEST1: Open the chart update wizard with default values and verify the default Account Code Digits is taken from the chart template or set to 6 — OK
  • TEST2: Change Account Code Digits in the wizard and verify that the company value is only persisted after updating the accounts — OK
  • TEST3: Update of all eligible accounts according to the configured code digits — NOT OK. Some accounts are not updated even though they were not manually created. An image is attached showing the accounts that remain with the old code length, and another image shows the chart update wizard where these accounts are not listed for update. These accounts are expected to be part of the chart and therefore should be considered in the update. Is required a need review?
Image Image
  • TEST4: Reopen the chart update wizard after applying the update and verify that the persisted Account Code Digits value is correctly loaded by default — OK

@u0f u0f force-pushed the add-account_chart_update_code_digits branch from cf4a275 to 0a3539c Compare January 8, 2026 09:18
@u0f u0f requested a review from EmilioPascual January 8, 2026 09:18
@u0f
Copy link
Author

u0f commented Jan 8, 2026

  • TEST3: Update of all eligible accounts according to the configured code digits — NOT OK. Some accounts are not updated even though they were not manually created. An image is attached showing the accounts that remain with the old code length, and another image shows the chart update wizard where these accounts are not listed for update. These accounts are expected to be part of the chart and therefore should be considered in the update. Is required a need review?

@Gelojr Thanks for your review. After looking, this is not a bug, is a limitation due to the Odoo account chart template. To manage this error, I added a log output that notify the user some account could not be updated and need manual change.

image

@u0f u0f force-pushed the add-account_chart_update_code_digits branch from 0a3539c to fae4a2e Compare January 8, 2026 09:24
@u0f u0f force-pushed the add-account_chart_update_code_digits branch from fae4a2e to e498142 Compare January 13, 2026 09:21
@u0f u0f requested a review from EmilioPascual January 13, 2026 09:23
@u0f u0f force-pushed the add-account_chart_update_code_digits branch from e498142 to 4a0c148 Compare January 13, 2026 13:16
@u0f u0f requested a review from EmilioPascual January 13, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants