-
-
Notifications
You must be signed in to change notification settings - Fork 859
[ADD] account_chart_update_code_digits: New module #2192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
947e76e to
984a0e5
Compare
account_chart_update_code_digits/wizards/wizard_chart_update.py
Outdated
Show resolved
Hide resolved
902f926 to
f2a3601
Compare
EmilioPascual
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm testing the module and I'm thinking the behavior is incomplete. The codes are not updated when you select new value in code digits. Maybe, you should see #2177
Please, add oca image to description.
f2a3601 to
df1d7ce
Compare
account_chart_update_code_digits/wizards/wizard_chart_update.py
Outdated
Show resolved
Hide resolved
df1d7ce to
cf4a275
Compare
EmilioPascual
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @u0f
Gelojr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @u0f. Thank you for the effort but i think a review is required.
The following tests have been performed.
- TEST1: Open the chart update wizard with default values and verify the default Account Code Digits is taken from the chart template or set to 6 — OK
- TEST2: Change Account Code Digits in the wizard and verify that the company value is only persisted after updating the accounts — OK
- TEST3: Update of all eligible accounts according to the configured code digits — NOT OK. Some accounts are not updated even though they were not manually created. An image is attached showing the accounts that remain with the old code length, and another image shows the chart update wizard where these accounts are not listed for update. These accounts are expected to be part of the chart and therefore should be considered in the update. Is required a need review?
- TEST4: Reopen the chart update wizard after applying the update and verify that the persisted Account Code Digits value is correctly loaded by default — OK
cf4a275 to
0a3539c
Compare
@Gelojr Thanks for your review. After looking, this is not a bug, is a limitation due to the Odoo account chart template. To manage this error, I added a log output that notify the user some account could not be updated and need manual change.
|
0a3539c to
fae4a2e
Compare
account_chart_update_code_digits/wizards/wizard_chart_update.py
Outdated
Show resolved
Hide resolved
account_chart_update_code_digits/wizards/wizard_chart_update.py
Outdated
Show resolved
Hide resolved
fae4a2e to
e498142
Compare
account_chart_update_code_digits/wizards/wizard_chart_update.py
Outdated
Show resolved
Hide resolved
…te_code_digits MT-12933 @moduon
e498142 to
4a0c148
Compare

This new module adds new logic for the number of digits in accounting accounts.
https://www.loom.com/share/5dbbb3b0d0774c1da417d49cf57fc833
MT-12933 @moduon